You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/28 20:56:45 UTC
[GitHub] [geode] karensmolermiller commented on a change in pull request #5684: GEODE-8570: deprecate cluster-configuration-dir property
karensmolermiller commented on a change in pull request #5684:
URL: https://github.com/apache/geode/pull/5684#discussion_r513754105
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -117,7 +117,7 @@ Valid values are in the range 0...2147483647</td>
</tr>
<tr>
<td>cluster-configuration-dir</td>
-<td>This property specifies the directory in which the cluster configuration related disk-store and artifacts are stored. This property is only applicable to dedicated locators that have "enable-cluster-configuration" set to true.</td>
+<td><b>Deprecated.</b> Use import/export clutser-configuration command instead. This property specifies the directory in which the cluster configuration related disk-store and artifacts are stored. This property is only applicable to dedicated locators that have "enable-cluster-configuration" set to true.</td>
Review comment:
I only looked at the docs portion of this PR.
1. Please change "clutser" to "cluster"
2. Please add "gfsh" in to this sentence, since we're not substituting a different property, and I think that you mean to use a gfsh command instead. Something like "Use the gfsh import or export cluster-configuration command instead."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org