You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by ja...@apache.org on 2018/05/24 00:59:54 UTC
samza git commit: SAMZA-1540: SystemProducer instance for
StreamAppender should have task.drop.producer.errors==true
Repository: samza
Updated Branches:
refs/heads/master 8f8e7bcb9 -> dfc1508aa
SAMZA-1540: SystemProducer instance for StreamAppender should have task.drop.producer.errors==true
vjagadish1989 Kindly take a look, thanks.
Author: Pawas Chhokra <pc...@pchhokra-mn2.linkedin.biz>
Reviewers: Jagadish <ja...@apache.org>
Closes #522 from PawasChhokra/SAMZA-1540_ChangesToStreamAppender
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/dfc1508a
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/dfc1508a
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/dfc1508a
Branch: refs/heads/master
Commit: dfc1508aaf3689ed2ac9751619aad10f9a638c07
Parents: 8f8e7bc
Author: Pawas Chhokra <pc...@pchhokra-mn2.linkedin.biz>
Authored: Wed May 23 17:59:51 2018 -0700
Committer: Jagadish <jv...@linkedin.com>
Committed: Wed May 23 17:59:51 2018 -0700
----------------------------------------------------------------------
.../java/org/apache/samza/logging/log4j/StreamAppender.java | 5 +++++
1 file changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/dfc1508a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
----------------------------------------------------------------------
diff --git a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
index ab29b71..5278284 100644
--- a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
+++ b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
@@ -19,6 +19,7 @@
package org.apache.samza.logging.log4j;
+import com.google.common.collect.ImmutableMap;
import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.net.URL;
@@ -34,8 +35,10 @@ import org.apache.samza.SamzaException;
import org.apache.samza.config.Config;
import org.apache.samza.config.JobConfig;
import org.apache.samza.config.Log4jSystemConfig;
+import org.apache.samza.config.MapConfig;
import org.apache.samza.config.SerializerConfig;
import org.apache.samza.config.ShellCommandConfig;
+import org.apache.samza.config.TaskConfig;
import org.apache.samza.coordinator.JobModelManager;
import org.apache.samza.job.model.JobModel;
import org.apache.samza.logging.log4j.serializers.LoggingEventJsonSerdeFactory;
@@ -275,6 +278,8 @@ public class StreamAppender extends AppenderSkeleton {
} catch (IOException e) {
throw new SamzaException("can not read the config", e);
}
+ // Make system producer drop producer errors for StreamAppender
+ config = new MapConfig(config, ImmutableMap.of(TaskConfig.DROP_PRODUCER_ERROR(), "true"));
return config;
}