You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2012/07/11 05:14:40 UTC
Review Request: CS-15521 Xenserver based User VM failed to HA when vrouter
runs on ESXi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5903/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Description
-------
Change:
return false as an answer when executing PingTestCommand in VMwareResource
Parent patch:
https://reviews.apache.org/r/5738/
they are not related, but the line number has been changed in the parent patch
This addresses bug CS-15521.
Diffs
-----
core/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b52d441
Diff: https://reviews.apache.org/r/5903/diff/
Testing
-------
Thanks,
mice xia
Re: Review Request: CS-15521 Xenserver based User VM failed to HA when
vrouter runs on ESXi
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5903/#review9506
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On July 26, 2012, 5:09 p.m., mice xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5903/
> -----------------------------------------------------------
>
> (Updated July 26, 2012, 5:09 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and edison su.
>
>
> Description
> -------
>
> Change:
> return false as an answer when executing PingTestCommand in VMwareResource
>
> Parent patch:
> https://reviews.apache.org/r/5738/
> they are not related, but the line number has been changed in the parent patch
>
>
> This addresses bug CS-15521.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 685a321
>
> Diff: https://reviews.apache.org/r/5903/diff/
>
>
> Testing
> -------
>
> one xs cluster with two XS, one vmware cluster, in the same pod. vrouter on vmware cluster
> start HA-enabled XS-based VM and shutdown the XS it belongs to, VM restarts on the other XS successfully
>
>
> Thanks,
>
> mice xia
>
>
Re: Review Request: CS-15521 Xenserver based User VM failed to HA when
vrouter runs on ESXi
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5903/
-----------------------------------------------------------
(Updated July 26, 2012, 5:09 p.m.)
Review request for cloudstack, Abhinandan Prateek and edison su.
Changes
-------
implement pingTestCommand in vmwareResource, ssh to vrouter and execute ping command
Description
-------
Change:
return false as an answer when executing PingTestCommand in VMwareResource
Parent patch:
https://reviews.apache.org/r/5738/
they are not related, but the line number has been changed in the parent patch
This addresses bug CS-15521.
Diffs (updated)
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 685a321
Diff: https://reviews.apache.org/r/5903/diff/
Testing (updated)
-------
one xs cluster with two XS, one vmware cluster, in the same pod. vrouter on vmware cluster
start HA-enabled XS-based VM and shutdown the XS it belongs to, VM restarts on the other XS successfully
Thanks,
mice xia
Re: Review Request: CS-15521 Xenserver based User VM failed to HA when
vrouter runs on ESXi
Posted by disheng su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5903/#review9417
-----------------------------------------------------------
The correct way is ssh into router vm, then ping user vm ip address. As pingtestcommand is testing user vm's aliveness, need to make sure pingtestcommand returns the correct vm status. Take scripts/vm/pingtest.sh as an example.
- disheng su
On July 11, 2012, 3:14 a.m., mice xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5903/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 3:14 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Change:
> return false as an answer when executing PingTestCommand in VMwareResource
>
> Parent patch:
> https://reviews.apache.org/r/5738/
> they are not related, but the line number has been changed in the parent patch
>
>
> This addresses bug CS-15521.
>
>
> Diffs
> -----
>
> core/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b52d441
>
> Diff: https://reviews.apache.org/r/5903/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> mice xia
>
>