You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/02 08:43:34 UTC
[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #7116: [Fix-7093][dolphincheduler-server] fix dependent node stuck in running
caishunfeng commented on a change in pull request #7116:
URL: https://github.com/apache/dolphinscheduler/pull/7116#discussion_r760870327
##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java
##########
@@ -92,9 +92,10 @@ private void checkTask() {
for (TaskInstance taskInstance : this.taskInstanceCheckList.values()) {
if (TimeoutFlag.OPEN == taskInstance.getTaskDefine().getTimeoutFlag()) {
long timeRemain = DateUtils.getRemainTime(taskInstance.getStartTime(), taskInstance.getTaskDefine().getTimeout() * Constants.SEC_2_MINUTES_TIME_UNIT);
- if (0 <= timeRemain && processTimeout(taskInstance)) {
+ if (0 >= timeRemain && processTimeout(taskInstance)) {
taskInstanceCheckList.remove(taskInstance.getId());
- return;
+ } else {
+ processDependCheck(taskInstance);
Review comment:
maybe this else logic should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org