[GitHub] [doris] morningman commented on a diff in pull request #18816: [Enchancement](auth) Forbid to login doris from 127.0.0.1 without password

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #18816:
URL: https://github.com/apache/doris/pull/18816#discussion_r1174832591


##########
docs/en/docs/admin-manual/privilege-ldap/user-privilege.md:
##########
@@ -236,9 +236,9 @@ ADMIN_PRIV and GRANT_PRIV have the authority of **"grant authority"** at the sam
 
 5. Forget passwords
 
-	If you forget your password and cannot log in to Doris, you can log in to Doris without a password using the following command on the machine where the Doris FE node is located:
+	If you forget your password and cannot log in to Doris, you can add `skip_localhost_auth_check` in fe config so that logging to Doris without a password in localhost.

Review Comment:
   Do we need to restart FE? If yes, please add it in doc



##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2116,5 +2116,12 @@ public class Config extends ConfigBase {
      */
     @ConfField(mutable = true)
     public static boolean infodb_support_ext_catalog = false;
+
+    /**
+     * If true, auth check will be disabled. The default value is false.
+     * This is to solve the case that user forgot the password.
+     */
+    @ConfField(mutable = true)

Review Comment:
   The mutable should be `false`, otherwise user can set it via http api



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org