You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2024/05/17 13:06:56 UTC
[PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
raiden00pl opened a new pull request, #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398
## Summary
- examples/nxscope: add static to private functions
- nxscope: add sensor streaming tool
This tool allows you to send sensor data via the nxscope interface.
Useful when we test sensors or when we just need a tool to visualize
data from sensors.
Works only with the new sensor framework.
## Impact
## Testing
thingy53 and nxscli tool
<img width="660" alt="2024-05-17_14-53" src="https://github.com/apache/nuttx-apps/assets/6563055/9c29ae7d-ce1a-4fdf-bb49-fdc971e003b2">
Below is an example of a data stream visualized with plotjuggler
<img width="1921" alt="2024-05-17_14-56" src="https://github.com/apache/nuttx-apps/assets/6563055/2e44661e-e48e-4bf7-80d4-bd3544f71418">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398#issuecomment-2126969094
yes, I'll add doc for this tool and some example configuration soon.
Currently, some instructions how to configure nxscope/nxscli to work with plotjuggler can be found here https://railab.me/posts/2024/1/plotjuggler-with-nxscope/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398#discussion_r1605695689
##########
logging/nxscope/sensors/CMakeLists.txt:
##########
@@ -0,0 +1,31 @@
+# ##############################################################################
+# apps/logging/nxscope/sensors/CMakeLists.txt
Review Comment:
I agree, moved to apps/system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398#discussion_r1607439942
##########
system/nxscope_sensors/Kconfig:
##########
@@ -0,0 +1,72 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig SYSTEM_NXSCOPE_SENSORS
+ bool "NxScope sensors stream app"
+ default n
+ depends on LOGGING_NXSCOPE
+ select LOGGING_NXSCOPE_INTF_SERIAL
+ select LOGGING_NXSCOPE_PROTO_SER
+
+if SYSTEM_NXSCOPE_SENSORS
+
+config NXSCOPE_SENSORS_PROGNAME
Review Comment:
All `NXSCOPE_SENSORS_` to `SYSTEM_SENSORSCOPE_`
##########
system/nxscope_sensors/Makefile:
##########
@@ -0,0 +1,36 @@
+############################################################################
+# apps/system/nxscope_sensors/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+# nxscope built-in application info
Review Comment:
```suggestion
# sensorscope built-in application info
```
##########
system/nxscope_sensors/Make.defs:
##########
@@ -0,0 +1,23 @@
+############################################################################
+# apps/systen/nxscope_sensors/Make.defs
Review Comment:
```suggestion
# apps/system/sensorscope/Make.defs
```
##########
system/nxscope_sensors/Kconfig:
##########
@@ -0,0 +1,72 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig SYSTEM_NXSCOPE_SENSORS
Review Comment:
```suggestion
menuconfig SYSTEM_SENSORSCOPE
```
##########
system/nxscope_sensors/nxscope_main.c:
##########
@@ -0,0 +1,555 @@
+/****************************************************************************
+ * apps/system/nxscope_sensors/nxscope_main.c
Review Comment:
```suggestion
* apps/system/sensorscope/sensorscope.c
```
##########
system/nxscope_sensors/Kconfig:
##########
@@ -0,0 +1,72 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig SYSTEM_NXSCOPE_SENSORS
+ bool "NxScope sensors stream app"
+ default n
+ depends on LOGGING_NXSCOPE
+ select LOGGING_NXSCOPE_INTF_SERIAL
+ select LOGGING_NXSCOPE_PROTO_SER
+
+if SYSTEM_NXSCOPE_SENSORS
+
+config NXSCOPE_SENSORS_PROGNAME
+ string "Program name"
+ default "sensors"
Review Comment:
```suggestion
default "sensorscope"
```
##########
system/nxscope_sensors/Makefile:
##########
@@ -0,0 +1,36 @@
+############################################################################
+# apps/system/nxscope_sensors/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+# nxscope built-in application info
+
+PROGNAME = $(CONFIG_NXSCOPE_SENSORS_PROGNAME)
+PRIORITY = $(CONFIG_NXSCOPE_SENSORS_PRIORITY)
+STACKSIZE = $(CONFIG_NXSCOPE_SENSORS_STACKSIZE)
+MODULE = $(CONFIG_NXSCOPE_SENSORS)
+
+# NxScope example
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398#issuecomment-2126180848
> ## Summary
> * examples/nxscope: add static to private functions
> * nxscope: add sensor streaming tool
> This tool allows you to send sensor data via the nxscope interface.
> Useful when we test sensors or when we just need a tool to visualize
> data from sensors.
> Works only with the new sensor framework.
>
> ## Impact
> new tool
>
> ## Testing
> thingy53 and nxscli tool
>
> <img alt="2024-05-17_14-53" width="660" src="https://private-user-images.githubusercontent.com/6563055/331601803-9c29ae7d-ce1a-4fdf-bb49-fdc971e003b2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY0MzY1MTEsIm5iZiI6MTcxNjQzNjIxMSwicGF0aCI6Ii82NTYzMDU1LzMzMTYwMTgwMy05YzI5YWU3ZC1jZTFhLTRmZGYtYmI0OS1mZGM5NzFlMDAzYjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MjNUMDM1MDExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzMzNDU1Y2Q0ZDEyNmVhMDgyMjE5MWU4Yzk1ZWUzMGQ5Mzg5OWIyMDUzMjZhNTU3NDNkNGJmYmYwZjZiNWY5YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.BE559EJwjB-dzQyxTXODZqViOvLZTDP6P4JO0NRSCQk">
> Below is an example of a data stream visualized with plotjuggler
>
> <img alt="2024-05-17_14-56" width="1921" src="https://private-user-images.githubusercontent.com/6563055/331601996-2e44661e-e48e-4bf7-80d4-bd3544f71418.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY0MzY1MTEsIm5iZiI6MTcxNjQzNjIxMSwicGF0aCI6Ii82NTYzMDU1LzMzMTYwMTk5Ni0yZTQ0NjYxZS1lNDhlLTRiZjctODBkNC1iZDM1NDRmNzE0MTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MjNUMDM1MDExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDc2ZGI0NjhlNGRmMjZkYWQxZTQ0MWJkMzlhMzU2YjUwMmU1NzM0YzkzZmMzMzRjMDdlODZlNDRkNTk5YjBlNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.pahYhI6AjuvkiDrbG5qGMDyzre0sC1karB7GYtQEk-s">
sensorscope is very useful to visualize the sensor data, could you move this nice picture to nuttx/Documentation folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398#discussion_r1605669415
##########
logging/nxscope/sensors/CMakeLists.txt:
##########
@@ -0,0 +1,31 @@
+# ##############################################################################
+# apps/logging/nxscope/sensors/CMakeLists.txt
Review Comment:
@raiden00pl do you think that apps/testing or apps/system is better to host sensor scope than apps/logging/nxscope/sensors? Since apps/logging/nxscope/sensors is a pure library before this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] logging/nxscope: add tool to stream sensor data [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2398:
URL: https://github.com/apache/nuttx-apps/pull/2398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org