You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Mark Miller (Jira)" <ji...@apache.org> on 2019/09/15 01:57:00 UTC
[jira] [Comment Edited] (SOLR-13753) Get GitHub to run 'ant
precommit' as an action for all PRs
[ https://issues.apache.org/jira/browse/SOLR-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929865#comment-16929865 ]
Mark Miller edited comment on SOLR-13753 at 9/15/19 1:56 AM:
-------------------------------------------------------------
Or I should say it just doesn't work well yet. The only workflows that will show up in GitHub UI are the ones specified in master - so you can configure other branches to also work in master, from that perspective you are fine. Where it's supposed to get better any day now is making changes or adding a workflow in another branch - right now those might as well not exist and it's just the workflows in the default branch (currently master). Your workflow in master working against other branches should be fine though.
was (Author: markrmiller@gmail.com):
Or I should say it just doesn't work well yet. The only workflows that will show up in GitHub UI are the ones specified in master - so you can configure other branches to also work in master, from that perspective you are find. Where it's supposed to get better any day now is making changes or adding a workflow in another branch - right now those might as well not exist and it's just the workflows in the default branch (currently master).
> Get GitHub to run 'ant precommit' as an action for all PRs
> ----------------------------------------------------------
>
> Key: SOLR-13753
> URL: https://issues.apache.org/jira/browse/SOLR-13753
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Get GitHub to run 'ant precommit' as a check for all PRs. This would make things much nicer as GitHub would run the checks for us and it's easier to track and fix when precommits are broken.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org