You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "mike-mcgann (via GitHub)" <gi...@apache.org> on 2023/02/07 20:00:52 UTC

[GitHub] [daffodil] mike-mcgann commented on a diff in pull request #947: Add scalafmt

mike-mcgann commented on code in PR #947:
URL: https://github.com/apache/daffodil/pull/947#discussion_r1099145637


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/DFDLEscapeScheme.scala:
##########
@@ -36,8 +36,11 @@ import org.apache.daffodil.lib.schema.annotation.props.PropertyLookupResult
 import org.apache.daffodil.lib.schema.annotation.props.NotFound
 import org.apache.daffodil.lib.schema.annotation.props.Found

Review Comment:
   This was a little confusing. There is a separate option that also needs to be included:
   
       rewrite.rules = [Imports]
   
   and that only sorted imports there were on the same line. If I enable group sorting, then it sorts "vertically". I've set this to create three separate groups:
   
       rewrite.imports.groups = [
           ["scala\\..*", "java\\..*", "javax\\..*"],
           ["org\\.apache\\.daffodil\\..*"],
       ]
   
   Standard libraries first, then daffodil, and followed by everything else. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org