You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/13 12:06:23 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
HyukjinKwon opened a new pull request #35193:
URL: https://github.com/apache/spark/pull/35193
### What changes were proposed in this pull request?
This PR is a retry of https://github.com/apache/spark/pull/35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link.
The main difference with the PR https://github.com/apache/spark/pull/35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark:
https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74
Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert.
### Why are the changes needed?
For developers to see the test report, and they can easily detect which test is failed.
### Does this PR introduce _any_ user-facing change?
No, dev-only
### How was this patch tested?
Tested in https://github.com/HyukjinKwon/spark/pull/51.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35193:
URL: https://github.com/apache/spark/pull/35193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012114307
Looks good in my test PR: https://github.com/Yikun/spark/pull/63
- it point to test result page: https://github.com/Yikun/spark/runs/4803229384
- details run_id: https://api.github.com/repos/Yikun/spark/actions/runs/1692697888, contains the status of `Build and test`, this can be used by update_build_status.yml as before
I think everything is ok this time. this PR only pluses the request in create PR instead of plus the request in update_build_status job (it's also better than https://github.com/apache/spark/pull/35192, ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012116451
Thanks! Let me merge this tomorrow so I can monitor other PRs in my day time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012618628
Thanks guys.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35193:
URL: https://github.com/apache/spark/pull/35193#discussion_r783916141
##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -119,13 +138,13 @@ jobs:
status: status,
output: {
title: 'Test results',
- summary: '[See test results](' + runUrl + ')',
+ summary: '[See test results](' + check_run_url + ')',
text: JSON.stringify({
owner: context.payload.pull_request.head.repo.owner.login,
repo: context.payload.pull_request.head.repo.name,
- run_id: runID
+ run_id: run_id
})
},
- details_url: runUrl,
+ details_url: actions_url,
Review comment:
Actually I think we can even remove this but let me keep it as is for now (https://github.community/t/create-a-check-run-details-url-is-not-being-set/166002). This is currently just a metadata for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012114307
Looks good in my test PR: https://github.com/Yikun/spark/pull/63
- it point to test result page: https://github.com/Yikun/spark/runs/4803229384
- details run_id: https://api.github.com/repos/Yikun/spark/actions/runs/1692697888, contains the status of `Build and test`, this can be used by update_build_status.yml as before
I think everything is ok this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012076366
@Yikun do you mind reviewing this when you find some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012114307
Looks good in my test PR: https://github.com/Yikun/spark/pull/63
- it point to test result page: https://github.com/Yikun/spark/runs/4803229384
- details run_id: https://api.github.com/repos/Yikun/spark/actions/runs/1692697888, contains the status of `Build and test`, this can be used by update_build_status.yml as before
I think everything is ok this time. this PR only pluses the request in create PR instead of plus the request in update_build_status job (it's also better than https://github.com/apache/spark/pull/35192).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012114307
Looks good in my test PR: https://github.com/Yikun/spark/pull/63
- it point to test result page: https://github.com/Yikun/spark/runs/4803229384
- details run_id: https://api.github.com/repos/Yikun/spark/actions/runs/1692697888, contains the status of `Build and test`, this can be used by update_build_status.yml as before
I think everything is ok this time. this PR only pluses the request in create PR instead of plus the request in update_build_status job (so it's better than https://github.com/apache/spark/pull/35192).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012114307
Looks good in my test PR: https://github.com/Yikun/spark/pull/63
- it point to test result page: https://github.com/Yikun/spark/runs/4803229384
- details run_id: https://api.github.com/repos/Yikun/spark/actions/runs/1692697888, contains the status of `Build and test`, this can be used by update_build_status.yml as before
I think everything is ok this time. And it's also better than https://github.com/apache/spark/pull/35192, it only pluses the request in create PR instead of plus the request in update_build_status job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35193: [SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35193:
URL: https://github.com/apache/spark/pull/35193#issuecomment-1012618470
Just to double check, I tested updating workload at https://github.com/HyukjinKwon/spark/runs/4810666021?check_suite_focus=true too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org