You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/12 22:39:31 UTC

[GitHub] [arrow] drin commented on pull request #13583: ARROW-16807: count distinct incorrectly merges state

drin commented on PR #13583:
URL: https://github.com/apache/arrow/pull/13583#issuecomment-1182562069

   I just realized that this introduces (or maybe just exposes) a bug when calling this function on scalar inputs. If the input is a scalar, `non_nulls` is incremented without changing state. To address this "correctly," the code path for scalar inputs should also update the state by using `GetOrInsert` as is done for the code path for vector inputs.
   
   I am working on figuring this out, given that the compiler has type conversion issues when attempting to just call `GetOrInsert` with a scalar reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org