You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/04/11 00:01:56 UTC
Re: Review Request 48917: Fixed docker fetcher 3xx redirect errors by
header attached.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48917/
-----------------------------------------------------------
(Updated April 10, 2017, 5:01 p.m.)
Review request for mesos, Avinash sridharan, Chun-Hung Hsiao, Artem Harutyunyan, Jie Yu, Timothy Chen, and Vinod Kone.
Summary (updated)
-----------------
Fixed docker fetcher 3xx redirect errors by header attached.
Bugs: MESOS-5172
https://issues.apache.org/jira/browse/MESOS-5172
Repository: mesos
Description (updated)
-------
The root cause for this issue is that, in private registry
like quay.io, layer download request will be redirected to
storage server in S3. However, the curl command with '-L'
handles HTTP redirection automatically, in which case HTTP
headers will be attached to all requests. AmazonS3 server
will return 400 Bad Request if HTTP Authorization header
is attached, with 'InvalidArgument' error code. So we need
to touch the given URL first to add extra logic for HTTP
redirections.
Please note that the download() method is changed to be
recursive since no header should be attached once the
request get authenticated.
Diffs (updated)
-----
src/uri/fetchers/docker.cpp d6d2e8e72554c5f96c3875af8ef93e0bc2107af6
Diff: https://reviews.apache.org/r/48917/diff/3/
Changes: https://reviews.apache.org/r/48917/diff/2-3/
Testing
-------
make check
Tested with quay.io/gilbertsong/inky manually.
Thanks,
Gilbert Song