You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/11/13 02:18:58 UTC
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 1:18 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Summary (updated)
-----------------
[7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs
-----
docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
Viewed with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review108671
-----------------------------------------------------------
Minor nits.
docs/authorization.md (line 13)
<https://reviews.apache.org/r/40271/#comment168127>
s/4./5.
docs/authorization.md (line 30)
<https://reviews.apache.org/r/40271/#comment168128>
s/6./7.
inor
- Alexander Rukletsov
On Nov. 14, 2015, 12:27 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2015, 12:27 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
> docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review108679
-----------------------------------------------------------
docs/authorization.md (line 13)
<https://reviews.apache.org/r/40271/#comment168138>
"create-volumes" and "destroy-volumes".
- Neil Conway
On Nov. 14, 2015, 12:27 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2015, 12:27 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
> docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 16, 2015, 2:39 p.m., Alexander Rukletsov wrote:
> > docs/authorization.md, line 43
> > <https://reviews.apache.org/r/40271/diff/5/?file=1156274#file1156274line43>
> >
> > As I have already mentioned in a previous review, we do not really enforce it, do we? That's why I think "valid" is a bit too strong, what do you think?
> >
> > Same holds for create/destroy volumes.
>
> Greg Mann wrote:
> I altered this text to be more descriptive of the current state of affairs, let me know if you think it should be changed further.
I think it's good now!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review110660
-----------------------------------------------------------
On Dec. 18, 2015, 11:19 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 11:19 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md 0b108bf96cf77b9e252306c0d694e9905d29939a
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 16, 2015, 2:39 p.m., Alexander Rukletsov wrote:
> > docs/authorization.md, line 43
> > <https://reviews.apache.org/r/40271/diff/5/?file=1156274#file1156274line43>
> >
> > As I have already mentioned in a previous review, we do not really enforce it, do we? That's why I think "valid" is a bit too strong, what do you think?
> >
> > Same holds for create/destroy volumes.
I altered this text to be more descriptive of the current state of affairs, let me know if you think it should be changed further.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review110660
-----------------------------------------------------------
On Dec. 18, 2015, 9:54 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 9:54 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review110660
-----------------------------------------------------------
docs/authorization.md (line 43)
<https://reviews.apache.org/r/40271/#comment170707>
As I have already mentioned in a previous review, we do not really enforce it, do we? That's why I think "valid" is a bit too strong, what do you think?
Same holds for create/destroy volumes.
- Alexander Rukletsov
On Dec. 8, 2015, 7:31 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:31 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review110665
-----------------------------------------------------------
docs/authorization.md (line 13)
<https://reviews.apache.org/r/40271/#comment170708>
I do not see authz code for master endpoints in the previous patches.
- Alexander Rukletsov
On Dec. 8, 2015, 7:31 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:31 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review109444
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39985, 39986, 39987, 39988, 39989, 40118, 40167, 40168, 40169, 40255, 40256, 40271]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 8, 2015, 7:31 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:31 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 11:19 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Addressed comment.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs (updated)
-----
docs/authorization.md 0b108bf96cf77b9e252306c0d694e9905d29939a
docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review111252
-----------------------------------------------------------
Ship it!
docs/authorization.md (line 11)
<https://reviews.apache.org/r/40271/#comment171353>
Looks like we are using `_xxx_` for those variables. Can you do a consistency fix?
- Jie Yu
On Dec. 18, 2015, 9:54 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 9:54 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review111193
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39985, 39986, 39987, 39988, 39989, 40118, 40167, 40168, 40169, 40255, 40256, 40271]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 18, 2015, 9:54 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 9:54 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 9:54 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Addressed comments, rebased.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs (updated)
-----
docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a
docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 7:31 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Addressed comments.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs (updated)
-----
docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 2, 2015, 5:19 p.m., Alexander Rukletsov wrote:
> > Do you think it makes sense to update "src/master/flags.cpp" as well?
I assume you're referring to the help string for the `--acls` flag? I think we could skip adding to that, since it already includes examples for three different types of ACLs.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review108675
-----------------------------------------------------------
On Dec. 8, 2015, 7:31 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:31 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md cf7a6bbb6044e460293dd66066df87aded0b4fb8
> docs/reservation.md de447664f10b1d73211805b725f2284b07c609f6
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review108675
-----------------------------------------------------------
Do you think it makes sense to update "src/master/flags.cpp" as well?
- Alexander Rukletsov
On Nov. 14, 2015, 12:27 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2015, 12:27 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
> docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 12:27 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs (updated)
-----
docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review106508
-----------------------------------------------------------
Bad patch!
Reviews applied: [39985, 39986, 39987, 39988, 39989, 40118, 40167, 40168, 40169, 40255]
Failed command: ./support/apply-review.sh -n -r 40255
Error:
2015-11-13 21:55:15 URL:https://reviews.apache.org/r/40255/diff/raw/ [15709/15709] -> "40255.patch" [1]
error: patch failed: src/master/master.cpp:3122
error: src/master/master.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 13, 2015, 9:31 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 9:31 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
> docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 9:31 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs (updated)
-----
docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review106502
-----------------------------------------------------------
Bad patch!
Reviews applied: [39985, 39986, 39987, 39988, 39989, 40118, 40167, 40168, 40169, 40255]
Failed command: ./support/apply-review.sh -n -r 40255
Error:
2015-11-13 21:25:13 URL:https://reviews.apache.org/r/40255/diff/raw/ [15709/15709] -> "40255.patch" [1]
error: patch failed: src/master/master.cpp:3122
error: src/master/master.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 13, 2015, 7:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 7:30 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
> docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 7:30 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Added to persistent-volume.md and reservation.md.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs (updated)
-----
docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
Diff: https://reviews.apache.org/r/40271/diff/
Testing
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Nov. 13, 2015, 10:58 a.m., Neil Conway wrote:
> > Should also update reservation.md and persistent-volume.md (at minimum, to remove "_Coming Soon_" from the notes about ACLs.)
Thanks, good call - added docs Re: authorization to those files.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review106397
-----------------------------------------------------------
On Nov. 13, 2015, 7:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 7:30 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
> docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
> docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review106397
-----------------------------------------------------------
Should also update reservation.md and persistent-volume.md (at minimum, to remove "_Coming Soon_" from the notes about ACLs.)
- Neil Conway
On Nov. 13, 2015, 1:23 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 1:23 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/#review106355
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39985, 39986, 39987, 39988, 39989, 40118, 40167, 40168, 40169, 40255, 40256, 40271]
All tests passed.
- Mesos ReviewBot
On Nov. 13, 2015, 1:23 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40271/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 1:23 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3062 and MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
>
>
> Diffs
> -----
>
> docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
>
> Diff: https://reviews.apache.org/r/40271/diff/
>
>
> Testing
> -------
>
> This is the last in a chain of 7 patches.
>
> This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
>
> `make check` was run after all patches in the chain were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40271: [7/7] Added documentation for RESERVE,
UNRESERVE, CREATE, and DESTROY authorization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40271/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 1:23 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3062 and MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3062
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.
Diffs
-----
docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
Diff: https://reviews.apache.org/r/40271/diff/
Testing (updated)
-------
This is the last in a chain of 7 patches.
This documentation was tested by viewing with the Mesos Website Container (https://github.com/mesosphere/mesos-website-container).
`make check` was run after all patches in the chain were applied.
Thanks,
Greg Mann