You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/02/02 15:42:37 UTC
[GitHub] couchdb-fauxton pull request: fix flaky test / race condition
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/638
fix flaky test / race condition
we init with an empty array, but the code expects a backbone
collection. if the connection is slow, we run into race conditions
as the store was not updated yet with a valid backbone collection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton reusably-modify-db
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/638.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #638
----
commit f430cd5b0cfca5f3dcfcf9db43bf848e4b55cf52
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-02-02T14:37:49Z
fix flaky test / race condition
we init with an empty array, but the code expects a backbone
collection. if the connection is slow, we run into race conditions
as the store was not updated yet with a valid backbone collection.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix flaky test / race condition
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/638#issuecomment-178696737
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix flaky test / race condition
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/638#issuecomment-178698010
merged as 478a3b3 - yay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix flaky test / race condition
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---