[jira] [Commented] (GEODE-8783) Publish batchesWithIncompleteTransactions in GatewaySenderMXBean

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248967#comment-17248967 ] 

ASF GitHub Bot commented on GEODE-8783:
---------------------------------------

albertogpz opened a new pull request #5845:
URL: https://github.com/apache/geode/pull/5845


   …rMXBean
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [X] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Publish batchesWithIncompleteTransactions in GatewaySenderMXBean
> ----------------------------------------------------------------
>
>                 Key: GEODE-8783
>                 URL: https://issues.apache.org/jira/browse/GEODE-8783
>             Project: Geode
>          Issue Type: Improvement
>          Components: docs, jmx, wan
>            Reporter: Alberto Gomez
>            Assignee: Alberto Gomez
>            Priority: Major
>
> It would be interesting to have a counter called "batchesWithIncompleteTransactions" in the GatewaySenderMXBean that shows the number of batches sent with incomplete transactions. 
> The reason is that it may not be guaranteed that all the events for a transaction will be sent in the same batch, even if group-transaction-events is enabled, due to a wrong configuration or under very high traffic conditions.
> It would be advisable to document this possibility and also relate it the new counter.
> For completeness sake, it would also be desirable to have batchesDistributed (given that batchesRedistributed and now batchesWithIncompleteTransactions) also published in the GatewaySenderMXBean.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)