[jira] [Commented] (HIVE-21641) Llap external client returns decimal columns in different precision/scale as compared to beeline

["Zoltan Haindrich (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981513#comment-16981513 ] 

Zoltan Haindrich commented on HIVE-21641:
-----------------------------------------

I think changing this to {{analyze.analyze}] kinda takes away the original benefits of doing this in the first place...by doing a full analyze it will do a bit more than just logical planning

I think it might worth a try to fix this the other way around - and make sure that {{genLogicalPlan}} ends up with the correct type....

cc: [~jcamachorodriguez]

> Llap external client returns decimal columns in different precision/scale as compared to beeline
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21641
>                 URL: https://issues.apache.org/jira/browse/HIVE-21641
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 3.1.1
>            Reporter: Shubham Chaurasia
>            Assignee: Shubham Chaurasia
>            Priority: Major
>              Labels: Branch3Candidate, pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21641.1.patch, HIVE-21641.2.patch, HIVE-21641.3.patch, HIVE-21641.4.patch, HIVE-21641.5.branch-3.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Llap external client gives different precision/scale as compared to when the query is executed beeline. Consider the following results:
> Query:
> {code} 
> select avg(ss_ext_sales_price) my_avg from store_sales;
> {code} 
> Result from Beeline
> {code} 
> +----------------------------+
> |           my_avg           |
> +----------------------------+
> | 37.8923531030581611189434  |
> +----------------------------+
> {code} 
> Result from Llap external client
> {code}
> +---------+
> |   my_avg|
> +---------+
> |37.892353|
> +---------+
> {code}
>  
> This is due to Driver(beeline path) calls [analyzeInternal()|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L328] for getting result set schema which initializes [resultSchema|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L333] after some more transformations as compared to llap-ext-client which calls [genLogicalPlan()|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java#L561]
> Replacing {{genLogicalPlan()}} by {{analyze()}} resolves this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)