Re: [PR] Use `BatchCoaleser` in Sort Merge Join, new benchmarks [datafusion]

["mbutrovich (via GitHub)" <gi...@apache.org>]

mbutrovich commented on PR #18875:
URL: https://github.com/apache/datafusion/pull/18875#issuecomment-3602737306

   I think I sorted out the corner case failures by refactoring a bit. I basically removed direct member access to `JoinedRecordBatches` fields and encapsulated their logic in functions sprinkled with `debug_assert` to make more sense of the control flow. There were some redundant `concat_batches` in the existing logic to begin with that already improved performance, but the `BatchCoalescer` makes it even better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org