You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/04/26 23:35:03 UTC

[GitHub] beam pull request #2720: [BEAM-2021] Rename StandardCoder to StructuredCoder

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2720

    [BEAM-2021] Rename StandardCoder to StructuredCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    StandardCoder has improper connotations - mainly, "Standard" as in
    "Standardized" as opposed to "Standard" as in "normal". StructuredCoder
    communicates the important part of the class, which is that the coder
    has some meaningful structure, and that structure can be used by a
    runner.
    
    Keep StandardCoder around as a temporary shim for the DataflowRunner.
    Will be removed as soon as an updated worker is available.
    
    To be merged after https://github.com/apache/beam/pull/2717
    
    R: @kennknowles or @lukecwik 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam structured_coder_not_standard_coder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2720.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2720
    
----
commit 8c6a31dc66e003616b681e9685aa7cd26091d064
Author: Thomas Groh <tg...@google.com>
Date:   2017-04-26T22:12:54Z

    Remove Coder Encoding IDs
    
    These were never safe to use, and will not be used once Coders have been
    migrated to the Runner API representation.

commit 2d61d90be3391dc8bbec42d54c63f22538d49387
Author: Thomas Groh <tg...@google.com>
Date:   2017-04-26T23:30:57Z

    Rename StandardCoder to StructuredCoder
    
    StandardCoder has improper connotations - mainly, "Standard" as in
    "Standardized" as opposed to "Standard" as in "normal". StructuredCoder
    communicates the important part of the class, which is that the coder
    has some meaningful structure, and that structure can be used by a
    runner.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2720: [BEAM-2021] Rename StandardCoder to StructuredCoder

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2720


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---