You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/01/19 12:40:45 UTC
[GitHub] brooklyn-server pull request #528: BROOKLYN-426: avoid propagating NoClassDe...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/528
BROOKLYN-426: avoid propagating NoClassDefFoundError
See https://issues.apache.org/jira/browse/BROOKLYN-426 for details.
Tested this with a badly behaving bundle, and confirmed that we were able to list the catalog contents when this fix is used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-426
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #528
----
commit 1c20df2590f7b2104d3f6f70b68a586d15bbc3f7
Author: Aled Sage <al...@gmail.com>
Date: 2017-01-19T12:38:52Z
BROOKLYN-426: avoid propagating NoClassDefFoundError
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #528: BROOKLYN-426: avoid propagating NoClassDe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #528: BROOKLYN-426: avoid propagating NoClassDe...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/528#discussion_r96872949
--- Diff: core/src/main/java/org/apache/brooklyn/util/core/LoaderDispatcher.java ---
@@ -44,6 +44,10 @@
return Maybe.<Class<?>>of(SystemFrameworkLoader.get().loadClassFromBundle(className, bundle));
} catch (ClassNotFoundException e) {
return Maybe.absent("Failed to load class " + className + " from bundle " + bundle, e);
+ } catch (NoClassDefFoundError e) {
--- End diff --
**MINOR**
```
} catch (ClassNotFoundException | NoClassDefFoundError e) {
return Maybe.absent("Failed to load class " + className + " from bundle " + bundle, e);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---