You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Maarten Billemont (JIRA)" <ji...@apache.org> on 2008/10/08 14:48:44 UTC

[jira] Commented: (WICKET-1864) MockHttpServletRequest does not support absolute redirection URLs.

    [ https://issues.apache.org/jira/browse/WICKET-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637905#action_12637905 ] 

Maarten Billemont commented on WICKET-1864:
-------------------------------------------

Make that code suggestion:


		url = getContextPath() +
			(redirect.charAt(0) == '/' ? redirect : (getServletPath() + "/" + redirect));

> MockHttpServletRequest does not support absolute redirection URLs.
> ------------------------------------------------------------------
>
>                 Key: WICKET-1864
>                 URL: https://issues.apache.org/jira/browse/WICKET-1864
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-M3
>            Reporter: Maarten Billemont
>
> Using the sendRedirect(String) method on an MockHttpServletRequest object causes bugged behaviour when the URL that is passed is absolute.
> The following code needs to change (line 1277):
> 		// We need to absolutize the redirect URL as we are not as smart as a web-browser
> 		// (WICKET-702)
> 		url = getContextPath() + getServletPath() + "/" + redirect;
> into, for example:
> 		// We need to absolutize the redirect URL as we are not as smart as a web-browser
> 		// (WICKET-702)
> 		url = redirect.charAt(0) == '/' ? redirect : redirect. getContextPath() + getServletPath() + "/" + redirect;
> After a few redirects I end up at:
> /BankApplication/BankApplication//BankApplication
> Which is not where I want to be.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.