You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/03 11:14:15 UTC

[GitHub] [superset] villebro commented on a diff in pull request #20088: fix: datatype tracking issue on virtual dataset

villebro commented on code in PR #20088:
URL: https://github.com/apache/superset/pull/20088#discussion_r888850005


##########
superset/db_engine_specs/postgres.py:
##########
@@ -21,6 +21,7 @@
 from typing import Any, Dict, List, Optional, Pattern, Tuple, TYPE_CHECKING
 
 from flask_babel import gettext as __
+from psycopg2.extensions import binary_types, string_types

Review Comment:
   I think this import should be moved into `get_datatype`, as `psycopg2` isn't a required dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org