You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/12/30 14:50:09 UTC

[GitHub] [incubator-echarts] yufeng04 opened a new pull request #11952: fix bug #11610 pagination disappear

yufeng04 opened a new pull request #11952: fix bug #11610 pagination disappear
URL: https://github.com/apache/incubator-echarts/pull/11952
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   -  bug fixing
   
   
   
   ### What does this PR do?
   To fix the bug #11611 
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   ## Details
   
   ### Before: Use the scroll legend and change to last page, the will pagination disappear when resizing the height of window.
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: I change the index of pagination to 0 when the pagination disappear.
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   ### Other information
   I have two options:
   1. Change the default value of the `defaultIndex` to `0`
   2. Change the index of pagination to 0 when the pagination disappear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] pissang commented on issue #11952: fix bug #11610 pagination disappear

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #11952: fix bug #11610 pagination disappear
URL: https://github.com/apache/incubator-echarts/pull/11952#issuecomment-569852484
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] pissang merged pull request #11952: fix bug #11610 pagination disappear

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #11952: fix bug #11610 pagination disappear
URL: https://github.com/apache/incubator-echarts/pull/11952
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org