[GitHub] [wicket] martin-g commented on a diff in pull request #556: WICKET-7029 Add wicket-migration module

["martin-g (via GitHub)" <gi...@apache.org>]

martin-g commented on code in PR #556:
URL: https://github.com/apache/wicket/pull/556#discussion_r1133495627


##########
pom.xml:
##########
@@ -119,7 +119,8 @@
 		<module>wicket-native-websocket</module>
 		<module>wicket-bean-validation</module>
 		<module>wicket-user-guide</module>
-	</modules>
+        <module>wicket-migration</module>

Review Comment:
   I think it would be good to rename this module (and its Java package) to include `9_to_10`. This way it could stay for several major releases and it won't collide with the next migration, e.g. `10_to_11`



##########
pom.xml:
##########
@@ -119,7 +119,8 @@
 		<module>wicket-native-websocket</module>
 		<module>wicket-bean-validation</module>
 		<module>wicket-user-guide</module>
-	</modules>
+        <module>wicket-migration</module>

Review Comment:
   Or even better let's introduce an intermediate Maven module for `migration` and then all `x_to_y` modules will be children of it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org