You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/03 10:19:52 UTC

[GitHub] [spark] maropu opened a new pull request #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

maropu opened a new pull request #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   A query below failed in branch-2.4;
   
   ```
   scala> sql("select array(array(1, 2), array(3)) ar").select(explode(explode($"ar"))).show()
   20/03/01 13:51:56 ERROR Executor: Exception in task 0.0 in stage 0.0 (TID 0)/ 1]
   java.lang.ClassCastException: scala.collection.mutable.ArrayOps$ofRef cannot be cast to org.apache.spark.sql.catalyst.util.ArrayData
   	at org.apache.spark.sql.catalyst.expressions.ExplodeBase.eval(generators.scala:313)
   	at org.apache.spark.sql.execution.GenerateExec.$anonfun$doExecute$8(GenerateExec.scala:108)
   	at scala.collection.Iterator$$anon$11.nextCur(Iterator.scala:484)
   	at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:490)
   	at scala.collection.Iterator$ConcatIterator.hasNext(Iterator.scala:222)
   	at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:458)
       ...
   ```
   
   This pr modified the `hasNestedGenerator` code in `ExtractGenerator` for correctly catching nested inner generators.
   
   This backport PR comes from https://github.com/apache/spark/pull/27750#
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   A bug fix.
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Added tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593877788
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23965/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593877264
 
 
   **[Test build #119226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119226/testReport)** for PR 27769 at commit [`2b8a618`](https://github.com/apache/spark/commit/2b8a6184678d59f48298029e098b66b9b3f9130c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593877264
 
 
   **[Test build #119226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119226/testReport)** for PR 27769 at commit [`2b8a618`](https://github.com/apache/spark/commit/2b8a6184678d59f48298029e098b66b9b3f9130c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-594152999
 
 
   Thank you, @maropu and @cloud-fan .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593988385
 
 
   Merged to branch-2.4.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593897787
 
 
   Thanks for the check, @cloud-fan ! Pending, Jenkins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593877788
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23965/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593976130
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119226/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593976125
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593877778
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593975359
 
 
   **[Test build #119226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119226/testReport)** for PR 27769 at commit [`2b8a618`](https://github.com/apache/spark/commit/2b8a6184678d59f48298029e098b66b9b3f9130c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu closed pull request #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
maropu closed pull request #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593877778
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593976130
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119226/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27769: [SPARK-30998][SQL][2.4] ClassCastException when a generator having nested inner generators
URL: https://github.com/apache/spark/pull/27769#issuecomment-593976125
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org