[GitHub] [echarts] mousne commented on pull request #17551: fix(theme): fix tooltips text style of the theme macarons

[GitBox <gi...@apache.org>]

mousne commented on PR #17551:
URL: https://github.com/apache/echarts/pull/17551#issuecomment-1226805312

   > Can you provide a renference to explain the changes because I cannot find this [in v4](https://github.com/apache/echarts/commit/728ae6394632fa9735402b06647a82d170caeede#diff-bc5445057729c8e5c43bac20e4b1835d6ce4d97c43536a2a3fe3a2b9cd0d92d6R54-R68).
   
   The details of the bug please see the [https://github.com/apache/echarts/issues/17542](https://github.com/apache/echarts/issues/17542)
   
   And a example is below,
   [V5](https://jsbin.com/jekucufani/edit?html,output)
   [v4](https://jsbin.com/toraqifeko/edit?html,console,output)
   
   You can view the different of tooltip show between the two version,
   then you can check the log which I console the option.tooltip.borderWidth as a example,
   there are some other option data is not same,
   so it's maybe not the theme's problem,
   somewhere have changed the default option value,
   but when I check the doc, there is same with the v4 version,
   so I think there are some code change make this problem,
   other theme also be affected,
   but I do not have enough time to check it, and I'm not familiar with the code.
   so this pr is only a fast solution with macarons theme,
   If you think it's not solve the problem completely, you can close this pr and check the code to fix the bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org