[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524752#comment-16524752 ] 

ASF GitHub Bot commented on FLINK-9666:
---------------------------------------

GitHub user lamber-ken opened a pull request:

    https://github.com/apache/flink/pull/6212

    [FLINK-9666] short-circuit logic should be used in boolean contexts

    ## What is the purpose of the change
      - short-circuit logic should be used in boolean contexts, | -> ||, & -> &&
    
    ## Brief change log
    
      - short-circuit logic should be used in boolean contexts, | -> ||, & -> &&
    
    ## Verifying this change
    
      - short-circuit logic should be used in boolean contexts, | -> ||, & -> &&
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lamber-ken/flink lamber-ken-fix-FLINK-9666

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6212
    
----
commit 1a8e1f6193823e70b1dc6abc1146299042c25c7d
Author: lamber-ken <!...@...>
Date:   2018-06-20T04:26:10Z

    add prometheus pushgateway reporter

commit 96a4bf7cd294bdfa079f3aae47114bbb013f52ac
Author: lamber-ken <!...@...>
Date:   2018-06-27T07:57:59Z

    short-circuit logic should be used in boolean contexts

commit 85e962e252bea2959419e0de4fdeaa474ef2b506
Author: lamber-ken <!...@...>
Date:   2018-06-27T08:10:07Z

    remove prometheus pushgateway

----


> short-circuit logic should be used in boolean contexts
> ------------------------------------------------------
>
>                 Key: FLINK-9666
>                 URL: https://issues.apache.org/jira/browse/FLINK-9666
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, DataStream API
>    Affects Versions: 1.5.0
>            Reporter: lamber-ken
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> short-circuit logic should be used in boolean contexts



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)