You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/22 13:39:46 UTC

[GitHub] [incubator-dolphinscheduler] woshiwuxiaofei commented on a change in pull request #4832: [Improvement-#4137][master] Replace sleep&take with poll in TaskPriorityQueueConsumer

woshiwuxiaofei commented on a change in pull request #4832:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4832#discussion_r580255764



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteProcessor.java
##########
@@ -95,8 +95,6 @@ public TaskExecuteProcessor() {
      * @param taskExecutionContext task
      */
     private void setTaskCache(TaskExecutionContext taskExecutionContext) {
-        TaskExecutionContext preTaskCache = new TaskExecutionContext();
-        preTaskCache.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
         taskExecutionContextCacheManager.cacheTaskExecutionContext(taskExecutionContext);

Review comment:
       I had ever second situation of you said, but new preTaskCache cached is required when only the id information needs to be cached




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org