You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2008/10/15 10:53:44 UTC
[jira] Created: (FELIX-770) Bundle Fragment Support check too
restrictive
Bundle Fragment Support check too restrictive
---------------------------------------------
Key: FELIX-770
URL: https://issues.apache.org/jira/browse/FELIX-770
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-1.2.1
Reporter: Felix Meschberger
As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
[1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls updated FELIX-770:
-----------------------------
Attachment: extension.patch
Could you try whether this patch works for you?
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Sub-task
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Assignee: Karl Pauls
> Fix For: felix-1.4.0
>
> Attachments: extension.patch, FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall updated FELIX-770:
----------------------------------
Issue Type: Sub-task (was: Bug)
Parent: FELIX-725
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Sub-task
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Fix For: felix-1.4.0
>
> Attachments: FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641381#action_12641381 ]
Felix Meschberger commented on FELIX-770:
-----------------------------------------
Karl, I just tested your patch and it seems to work.
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Sub-task
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Assignee: Karl Pauls
> Fix For: felix-1.4.0
>
> Attachments: extension.patch, FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls closed FELIX-770.
----------------------------
Resolution: Fixed
I commited the patch to trunk (rev 706792).
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Sub-task
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Assignee: Karl Pauls
> Fix For: felix-1.4.0
>
> Attachments: extension.patch, FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-770:
------------------------------------
Fix Version/s: felix-1.4.0
I think this should be included in the next release, because it is a blocker for us to upgrade from 1.0.4 to a more recent framework release. Thanks.
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Fix For: felix-1.4.0
>
> Attachments: FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-770:
------------------------------------
Attachment: FELIX-770.patch
Proposed patch excluding Framework Extension Bundles from Fragement-Host validation
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Attachments: FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls reassigned FELIX-770:
--------------------------------
Assignee: Karl Pauls
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Sub-task
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Assignee: Karl Pauls
> Fix For: felix-1.4.0
>
> Attachments: FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-770) Bundle Fragment Support check too
restrictive
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641145#action_12641145 ]
Richard S. Hall commented on FELIX-770:
---------------------------------------
Karl, I looked into applying this patch. Is the proposed check sufficient? The ExtensionManager.isExtensionBundle() method actually tests the values returned by ManifestParser.parseExtensionBundleHeader(), not just for null. Are these testing the same thing or something different? If it is the same, then perhaps we could just come up with one way of testing for it.
> Bundle Fragment Support check too restrictive
> ---------------------------------------------
>
> Key: FELIX-770
> URL: https://issues.apache.org/jira/browse/FELIX-770
> Project: Felix
> Issue Type: Sub-task
> Components: Framework
> Affects Versions: felix-1.2.1
> Reporter: Felix Meschberger
> Fix For: felix-1.4.0
>
> Attachments: FELIX-770.patch
>
>
> As indicated in [1], the validation of the Fragment-Host header in the ManifestParser.validateFragment is too restrictive in that it also throws or logs for Framework Extension bundles (fragments attached to the system bundle with an extension directive), because such Framework Extensions have long been supported.
> I think, just excluding such fragments from further inspection in the validateFragment method should do the trick.
> [1] http://markmail.org/message/55crz64j7qxi7c5u
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.