You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/05 04:16:54 UTC
[GitHub] [druid] suneet-s opened a new pull request #11551: Better logs for lookups
suneet-s opened a new pull request #11551:
URL: https://github.com/apache/druid/pull/11551
Update log levels for cache refreshes of lookups to INFO
This is helpful for debugging when a process might crash because of running
out of memory when trying to load a lookup. It's also helpful for an operator
to be able to look at the logs and tell when the lookups were updated since
this could impact query results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11551: Better logs for lookups
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11551:
URL: https://github.com/apache/druid/pull/11551#issuecomment-895282547
Do not merge - I need to do a few more local tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11551: Better logs for lookups
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11551:
URL: https://github.com/apache/druid/pull/11551#discussion_r683851215
##########
File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java
##########
@@ -235,10 +235,10 @@ private void tryUpdateCache(String currentVersion) throws Exception
if (previousCacheState instanceof VersionedCache) {
((VersionedCache) previousCacheState).close();
}
- log.debug("%s: the cache was successfully updated", this);
+ log.info("%s: the cache was successfully updated", this);
Review comment:
It would look something like this
```
namespace [JdbcExtractionNamespace{connectorConfig=DbConnectorConfig{createTables=true, connectURI='jdbc:mysql://connectionString', user=userName, passwordProvider=org.apache.druid.metadata.DefaultPasswordProvider, dbcpProperties=null}, table='my_table_name', keyColumn='my_key_column', valueColumn='my_value_column', tsColumn='null', filter='null', pollPeriod=PT0S}] :
org.apache.druid.server.lookup.namespace.cache.CacheScheduler$EntryImpl@1234abc```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a change in pull request #11551: Better logs for lookups
Posted by GitBox <gi...@apache.org>.
maytasm commented on a change in pull request #11551:
URL: https://github.com/apache/druid/pull/11551#discussion_r683664011
##########
File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java
##########
@@ -235,10 +235,10 @@ private void tryUpdateCache(String currentVersion) throws Exception
if (previousCacheState instanceof VersionedCache) {
((VersionedCache) previousCacheState).close();
}
- log.debug("%s: the cache was successfully updated", this);
+ log.info("%s: the cache was successfully updated", this);
Review comment:
Will the toString of `this` be large?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] egor-ryashin commented on a change in pull request #11551: Better logs for lookups
Posted by GitBox <gi...@apache.org>.
egor-ryashin commented on a change in pull request #11551:
URL: https://github.com/apache/druid/pull/11551#discussion_r686326659
##########
File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/CacheScheduler.java
##########
@@ -235,10 +235,10 @@ private void tryUpdateCache(String currentVersion) throws Exception
if (previousCacheState instanceof VersionedCache) {
((VersionedCache) previousCacheState).close();
}
- log.debug("%s: the cache was successfully updated", this);
+ log.info("%s: the cache was successfully updated", this);
Review comment:
Could we reduce that? looks like too verbose. We can log just name, time and size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org