[GitHub] [incubator-pinot] npawar commented on a change in pull request #4445: Refactor pinot-connectors to break the dependencies from kafka 0.9

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #4445: Refactor pinot-connectors to break the dependencies from kafka 0.9
URL: https://github.com/apache/incubator-pinot/pull/4445#discussion_r305461078
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/KafkaStarterUtils.java
 ##########
 @@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.tools;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Properties;
+import org.apache.pinot.common.utils.ZkStarter;
+import org.apache.pinot.core.realtime.stream.StreamDataProvider;
+import org.apache.pinot.core.realtime.stream.StreamDataServerStartable;
+
+
+public class KafkaStarterUtils {
+  public static final int DEFAULT_BROKER_ID = 0;
+  public static final String DEFAULT_ZK_STR = ZkStarter.DEFAULT_ZK_STR + "/kafka";
+  public static int DEFAULT_KAFKA_PORT = 19092;
+  public static final String DEFAULT_KAFKA_BROKER = "localhost:" + DEFAULT_KAFKA_PORT;
+
+  public static final String PORT = "port";
+  public static final String BROKER_ID = "broker.id";
+  private static final String ZOOKEEPER_CONNECT = "zookeeper.connect";
+  private static final String LOG_DIRS = "log.dirs";
+
+  public static final String KAFKA_09_SERVER_STARTABLE_CLASS_NAME =
+      "org.apache.pinot.core.realtime.impl.kafka.server.KafkaDataServerStartable";
 
 Review comment:
   is the expectation now that every kafka implementation should have the KafkaDataServerStartable in the path `org.apache.pinot.core.realtime.impl.kafka.server` if we want the pinot-tools/pinot-perf/pinot-integration-tests to run?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org