You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2015/01/20 17:15:24 UTC

qpid-jms git commit: Fix some issues in the test.

Repository: qpid-jms
Updated Branches:
  refs/heads/master 68d402ef1 -> b2bb91e89


Fix some issues in the test.

Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/b2bb91e8
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/b2bb91e8
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/b2bb91e8

Branch: refs/heads/master
Commit: b2bb91e8921e05162fb08937c6808655f8165e38
Parents: 68d402e
Author: Timothy Bish <ta...@gmail.com>
Authored: Tue Jan 20 11:14:55 2015 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Tue Jan 20 11:15:16 2015 -0500

----------------------------------------------------------------------
 .../qpid/jms/usecases/JmsLargeMessagesInGroupsTest.java     | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/b2bb91e8/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/usecases/JmsLargeMessagesInGroupsTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/usecases/JmsLargeMessagesInGroupsTest.java b/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/usecases/JmsLargeMessagesInGroupsTest.java
index e8d8fa5..0b29fea 100644
--- a/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/usecases/JmsLargeMessagesInGroupsTest.java
+++ b/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/usecases/JmsLargeMessagesInGroupsTest.java
@@ -27,12 +27,10 @@ import javax.jms.Queue;
 import javax.jms.Session;
 
 import org.apache.qpid.jms.support.AmqpTestSupport;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-@Ignore("Currently fails")
 public class JmsLargeMessagesInGroupsTest extends AmqpTestSupport {
 
     protected static final Logger LOG = LoggerFactory.getLogger(JmsLargeMessagesInGroupsTest.class);
@@ -42,9 +40,12 @@ public class JmsLargeMessagesInGroupsTest extends AmqpTestSupport {
     private static final int RECEIVE_TIMEOUT = 5000;
     private static final String JMSX_GROUP_ID = "JmsGroupsTest";
 
+    private int sequenceCount = 0;
+
     @Test
     public void testGroupSeqIsNeverLost() throws Exception {
         connection = createAmqpConnection();
+        connection.start();
 
         sendMessagesToBroker(MESSAGE_COUNT);
         readMessagesOnBroker(MESSAGE_COUNT);
@@ -66,6 +67,8 @@ public class JmsLargeMessagesInGroupsTest extends AmqpTestSupport {
             LOG.info("Message assigned JMSXGroupID := {}", gid);
             LOG.info("Message assigned JMSXGroupSeq := {}", seq);
         }
+
+        consumer.close();
     }
 
     protected void sendMessagesToBroker(int count) throws Exception {
@@ -86,7 +89,7 @@ public class JmsLargeMessagesInGroupsTest extends AmqpTestSupport {
             BytesMessage message = session.createBytesMessage();
             message.setJMSDeliveryMode(DeliveryMode.PERSISTENT);
             message.setStringProperty("JMSXGroupID", JMSX_GROUP_ID);
-            message.setIntProperty("JMSXGroupSeq", i);
+            message.setIntProperty("JMSXGroupSeq", ++sequenceCount);
             message.writeBytes(buffer);
             producer.send(message);
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org