You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/04/15 12:32:19 UTC

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15736


Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................

IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Some tests are flaky due to timeouts in Hive queries on non-HDFS
filesystems. Until IMPALA-9365 is resolved we only run these tests
when the target filesystem is HDFS.

Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
---
M tests/query_test/test_mt_dop.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_scanners.py
M tests/query_test/test_scanners_fuzz.py
4 files changed, 16 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/15736/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15736/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/15736/1/tests/query_test/test_scanners.py@58
PS1, Line 58: from tests.util.filesystem_utils import IS_HDFS, WAREHOUSE, get_fs_path
flake8: F401 'tests.util.filesystem_utils.WAREHOUSE' imported but unused


http://gerrit.cloudera.org:8080/#/c/15736/1/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:

http://gerrit.cloudera.org:8080/#/c/15736/1/tests/query_test/test_scanners_fuzz.py@31
PS1, Line 31: from tests.util.filesystem_utils import IS_HDFS, WAREHOUSE, get_fs_path
flake8: F401 'tests.util.filesystem_utils.WAREHOUSE' imported but unused



-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 12:33:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5806/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 13:14:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 13:16:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 18:02:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5658/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 18:02:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................

IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Some tests are flaky due to timeouts in Hive queries on non-HDFS
filesystems. Until IMPALA-9365 is resolved we only run these tests
when the target filesystem is HDFS.

Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Reviewed-on: http://gerrit.cloudera.org:8080/15736
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_mt_dop.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_scanners.py
M tests/query_test/test_scanners_fuzz.py
4 files changed, 16 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15736 )

Change subject: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
Gerrit-Change-Number: 15736
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:18:16 +0000
Gerrit-HasComments: No