You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/11/20 20:26:28 UTC
Review Request 28292: CLOUDSTACK-7955 : Fixed the script
'test_project_limits.py' - Register Template in the Project to test the
Template limits on the project
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28292/
-----------------------------------------------------------
Review request for cloudstack and sangeetha hariharan.
Bugs: CLOUDSTACK-7955
https://issues.apache.org/jira/browse/CLOUDSTACK-7955
Repository: cloudstack-git
Description
-------
Based on Fix for CLOUDSTACK-7394, Caller should be owner after creating template from snapshot/volume. This requires the test case test_07_templates_per_project to be changed. The test case should test the limits by registering the template in the project instead of creating templates from Volumes.
Diffs
-----
test/integration/component/test_project_limits.py 5d37f0b
Diff: https://reviews.apache.org/r/28292/diff/
Testing
-------
Test Limit number of guest account specific networks ... === TestName: test_maxAccountNetworks | Status : SUCCESS ===
ok
Test project limits for domain admin ... === TestName: test_01_project_limits | Status : SUCCESS ===
ok
Test project limits for normal user ... === TestName: test_02_project_limits_normal_user | Status : SUCCESS ===
ok
Test VM limit per project ... === TestName: test_03_vm_per_project | Status : SUCCESS ===
ok
Test Public IP limit per project ... === TestName: test_04_publicip_per_project | Status : SUCCESS ===
ok
Test Snapshot limit per project ... === TestName: test_05_snapshots_per_project | Status : SUCCESS ===
ok
Test Volumes limit per project ... === TestName: test_06_volumes_per_project | Status : SUCCESS ===
ok
Test Templates limit per project ... === TestName: test_07_templates_per_project | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 1103.761s
OK
Thanks,
Chandan Purushothama
Re: Review Request 28292: CLOUDSTACK-7955 : Fixed the script
'test_project_limits.py' - Register Template in the Project to test the
Template limits on the project
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28292/#review79016
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Nov. 20, 2014, 7:26 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28292/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 7:26 p.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-7955
> https://issues.apache.org/jira/browse/CLOUDSTACK-7955
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Based on Fix for CLOUDSTACK-7394, Caller should be owner after creating template from snapshot/volume. This requires the test case test_07_templates_per_project to be changed. The test case should test the limits by registering the template in the project instead of creating templates from Volumes.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_limits.py 5d37f0b
>
> Diff: https://reviews.apache.org/r/28292/diff/
>
>
> Testing
> -------
>
> Test Limit number of guest account specific networks ... === TestName: test_maxAccountNetworks | Status : SUCCESS ===
> ok
> Test project limits for domain admin ... === TestName: test_01_project_limits | Status : SUCCESS ===
> ok
> Test project limits for normal user ... === TestName: test_02_project_limits_normal_user | Status : SUCCESS ===
> ok
> Test VM limit per project ... === TestName: test_03_vm_per_project | Status : SUCCESS ===
> ok
> Test Public IP limit per project ... === TestName: test_04_publicip_per_project | Status : SUCCESS ===
> ok
> Test Snapshot limit per project ... === TestName: test_05_snapshots_per_project | Status : SUCCESS ===
> ok
> Test Volumes limit per project ... === TestName: test_06_volumes_per_project | Status : SUCCESS ===
> ok
> Test Templates limit per project ... === TestName: test_07_templates_per_project | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 1103.761s
>
> OK
>
>
> Thanks,
>
> Chandan Purushothama
>
>
Re: Review Request 28292: CLOUDSTACK-7955 : Fixed the script
'test_project_limits.py' - Register Template in the Project to test the
Template limits on the project
Posted by sangeetha hariharan <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28292/#review62647
-----------------------------------------------------------
Ship it!
Ship It!
- sangeetha hariharan
On Nov. 20, 2014, 7:26 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28292/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 7:26 p.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-7955
> https://issues.apache.org/jira/browse/CLOUDSTACK-7955
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Based on Fix for CLOUDSTACK-7394, Caller should be owner after creating template from snapshot/volume. This requires the test case test_07_templates_per_project to be changed. The test case should test the limits by registering the template in the project instead of creating templates from Volumes.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_limits.py 5d37f0b
>
> Diff: https://reviews.apache.org/r/28292/diff/
>
>
> Testing
> -------
>
> Test Limit number of guest account specific networks ... === TestName: test_maxAccountNetworks | Status : SUCCESS ===
> ok
> Test project limits for domain admin ... === TestName: test_01_project_limits | Status : SUCCESS ===
> ok
> Test project limits for normal user ... === TestName: test_02_project_limits_normal_user | Status : SUCCESS ===
> ok
> Test VM limit per project ... === TestName: test_03_vm_per_project | Status : SUCCESS ===
> ok
> Test Public IP limit per project ... === TestName: test_04_publicip_per_project | Status : SUCCESS ===
> ok
> Test Snapshot limit per project ... === TestName: test_05_snapshots_per_project | Status : SUCCESS ===
> ok
> Test Volumes limit per project ... === TestName: test_06_volumes_per_project | Status : SUCCESS ===
> ok
> Test Templates limit per project ... === TestName: test_07_templates_per_project | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 1103.761s
>
> OK
>
>
> Thanks,
>
> Chandan Purushothama
>
>