You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/03/02 13:32:09 UTC

Review Request 74333: RANGER-4094: User_name/ group_name/ roles field of their tables clipping names more that 14-15 characters long.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74333/
-----------------------------------------------------------

Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.

Bugs: RANGER-4094
https://issues.apache.org/jira/browse/RANGER-4094

Repository: ranger

Description
-------

Behaviour in React UI:

User_name field of user table not fully showing more than 12 characters.

User_name field of user table not fully showing more than 14 characters.

User_name field of user table not fully showing more than 21 characters.

Behaviour in Backbone JS UI:

User_name field of user table not fully showing more than 30 characters.

Expected behaviour:

Analyse and see if its a requirement increase the no. of char visibility. As in legacy it allows more than 30 chars.

Steps to reproduce:
# Add users with long names(more that 15 chars).
# And navigate to the user in user table of users page of ranger UI.
# The name is only showing 12 chars and followed by ...

Diffs
-----

security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 73d5d4612
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx 7921b560c
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 8e0c0b580

Diff: https://reviews.apache.org/r/74333/diff/1/

Testing
-------

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
- User/Group/Role listing tables.

Thanks,

Brijesh Bhalala

Re: Review Request 74333: RANGER-4094: User_name/ group_name/ roles field of their tables clipping names more that 14-15 characters long.

Posted by Dhaval Rajpara <dh...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74333/#review225268
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Rajpara


On March 2, 2023, 1:32 p.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74333/
> -----------------------------------------------------------
> 
> (Updated March 2, 2023, 1:32 p.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4094
>     https://issues.apache.org/jira/browse/RANGER-4094
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Behaviour in React UI:
> 
> User_name field of user table not fully showing more than 12 characters.
> 
> User_name field of user table not fully showing more than 14 characters.
> 
> User_name field of user table not fully showing more than 21 characters.
> 
>  
> 
> Behaviour in Backbone JS UI:
> 
> User_name field of user table not fully showing more than 30 characters.
> 
> User_name field of user table not fully showing more than 30 characters.
> 
> User_name field of user table not fully showing more than 30 characters.
> 
>  
> 
> Expected behaviour:
> 
> Analyse and see if its a requirement increase the no. of char visibility. As in legacy it allows more than 30 chars.
> 
>  
> 
> Steps to reproduce:
>  # Add users with long names(more that 15 chars).
>  # And navigate to the user in user table of users page of ranger UI.
>  # The name is only showing 12 chars and followed by ...
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 73d5d4612 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx 7921b560c 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 8e0c0b580 
> 
> 
> Diff: https://reviews.apache.org/r/74333/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   - User/Group/Role listing tables.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 74333: RANGER-4094: User_name/ group_name/ roles field of their tables clipping names more that 14-15 characters long.

Posted by Mugdha Varadkar <mu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74333/#review225270
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On March 2, 2023, 1:32 p.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74333/
> -----------------------------------------------------------
> 
> (Updated March 2, 2023, 1:32 p.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4094
>     https://issues.apache.org/jira/browse/RANGER-4094
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Behaviour in React UI:
> 
> User_name field of user table not fully showing more than 12 characters.
> 
> User_name field of user table not fully showing more than 14 characters.
> 
> User_name field of user table not fully showing more than 21 characters.
> 
>  
> 
> Behaviour in Backbone JS UI:
> 
> User_name field of user table not fully showing more than 30 characters.
> 
> User_name field of user table not fully showing more than 30 characters.
> 
> User_name field of user table not fully showing more than 30 characters.
> 
>  
> 
> Expected behaviour:
> 
> Analyse and see if its a requirement increase the no. of char visibility. As in legacy it allows more than 30 chars.
> 
>  
> 
> Steps to reproduce:
>  # Add users with long names(more that 15 chars).
>  # And navigate to the user in user table of users page of ranger UI.
>  # The name is only showing 12 chars and followed by ...
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 73d5d4612 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx 7921b560c 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 8e0c0b580 
> 
> 
> Diff: https://reviews.apache.org/r/74333/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   - User/Group/Role listing tables.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>