[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #17318:
URL: https://github.com/apache/pulsar/pull/17318#discussion_r981184755


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -97,6 +98,9 @@
     protected volatile Timeout batchReceiveTimeout = null;
     protected final Lock reentrantLock = new ReentrantLock();
 
+    // Only work when subscription type is Failover or Exclusive
+    protected final Lock incomingQueueLock;

Review Comment:
   The `enqueueMessageAndCheckBatchReceive` method is always executed by the `internalPinnedExecutor` and the `redeliverUnacknowledgedMessages` method of `MultiTopicsConsumerImpl` is also executed by the `internalPinnedExecutor`. Is it possible to make sure the `redeliverUnacknowledgedMessages` method of the `ConsumerImpl` so that we don't need to introduce the lock here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org