You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shwetha GS <ss...@hortonworks.com> on 2015/08/11 11:32:14 UTC
Review Request 37349: ATLAS-91 Add solr configuration and
documentation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-91
https://issues.apache.org/jira/browse/ATLAS-91
Repository: atlas
Description
-------
Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4. Added function using reflection to override atlas's SolrIndex
Diffs
-----
client/pom.xml d393b3a
docs/src/site/twiki/InstallationSteps.twiki 0391c2d
pom.xml facd539
repository/pom.xml a2f8e08
repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 5e61b9a
src/conf/solr/currency.xml PRE-CREATION
src/conf/solr/lang/stopwords_en.txt PRE-CREATION
src/conf/solr/protwords.txt PRE-CREATION
src/conf/solr/schema.xml PRE-CREATION
src/conf/solr/solrconfig.xml PRE-CREATION
src/conf/solr/stopwords.txt PRE-CREATION
src/conf/solr/synonyms.txt PRE-CREATION
Diff: https://reviews.apache.org/r/37349/diff/
Testing
-------
UTs in distributed profile
Thanks,
Shwetha GS
Re: Review Request 37349: ATLAS-91 Add solr configuration and
documentation
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 5:43 a.m.)
Review request for atlas.
Changes
-------
Moved Solr5Index to titan package. Updated doc
Bugs: ATLAS-91
https://issues.apache.org/jira/browse/ATLAS-91
Repository: atlas
Description
-------
Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4. Added function using reflection to override atlas's SolrIndex
Diffs (updated)
-----
client/pom.xml d393b3a
docs/src/site/twiki/InstallationSteps.twiki 0391c2d
pom.xml facd539
repository/pom.xml a2f8e08
repository/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 5e61b9a
src/conf/solr/currency.xml PRE-CREATION
src/conf/solr/lang/stopwords_en.txt PRE-CREATION
src/conf/solr/protwords.txt PRE-CREATION
src/conf/solr/schema.xml PRE-CREATION
src/conf/solr/solrconfig.xml PRE-CREATION
src/conf/solr/stopwords.txt PRE-CREATION
src/conf/solr/synonyms.txt PRE-CREATION
Diff: https://reviews.apache.org/r/37349/diff/
Testing
-------
UTs in distributed profile
Thanks,
Shwetha GS
Re: Review Request 37349: ATLAS-91 Add solr configuration and
documentation
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/#review94907
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java (line 63)
<https://reviews.apache.org/r/37349/#comment149592>
Pls add some comments to understand why the change was done. Took a while to understand :).
- Suma Shivaprasad
On Aug. 11, 2015, 9:32 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37349/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 9:32 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-91
> https://issues.apache.org/jira/browse/ATLAS-91
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4. Added function using reflection to override atlas's SolrIndex
>
>
> Diffs
> -----
>
> client/pom.xml d393b3a
> docs/src/site/twiki/InstallationSteps.twiki 0391c2d
> pom.xml facd539
> repository/pom.xml a2f8e08
> repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 5e61b9a
> src/conf/solr/currency.xml PRE-CREATION
> src/conf/solr/lang/stopwords_en.txt PRE-CREATION
> src/conf/solr/protwords.txt PRE-CREATION
> src/conf/solr/schema.xml PRE-CREATION
> src/conf/solr/solrconfig.xml PRE-CREATION
> src/conf/solr/stopwords.txt PRE-CREATION
> src/conf/solr/synonyms.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37349/diff/
>
>
> Testing
> -------
>
> UTs in distributed profile
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 37349: ATLAS-91 Add solr configuration and
documentation
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/#review94908
-----------------------------------------------------------
Ship it!
+1. Thanks for taking this up Shwetha
- Suma Shivaprasad
On Aug. 11, 2015, 9:32 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37349/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 9:32 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-91
> https://issues.apache.org/jira/browse/ATLAS-91
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4. Added function using reflection to override atlas's SolrIndex
>
>
> Diffs
> -----
>
> client/pom.xml d393b3a
> docs/src/site/twiki/InstallationSteps.twiki 0391c2d
> pom.xml facd539
> repository/pom.xml a2f8e08
> repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 5e61b9a
> src/conf/solr/currency.xml PRE-CREATION
> src/conf/solr/lang/stopwords_en.txt PRE-CREATION
> src/conf/solr/protwords.txt PRE-CREATION
> src/conf/solr/schema.xml PRE-CREATION
> src/conf/solr/solrconfig.xml PRE-CREATION
> src/conf/solr/stopwords.txt PRE-CREATION
> src/conf/solr/synonyms.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37349/diff/
>
>
> Testing
> -------
>
> UTs in distributed profile
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 37349: ATLAS-91 Add solr configuration and
documentation
Posted by Shwetha GS <ss...@hortonworks.com>.
> On Aug. 11, 2015, 6:49 p.m., Seetharam Venkatesh wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java, line 19
> > <https://reviews.apache.org/r/37349/diff/1/?file=1037524#file1037524line19>
> >
> > Why cant I retain the titan package here? Dont you think this becomes confusing?
Yes, we can retain the package name. But I don't think it will be any less confusing
> On Aug. 11, 2015, 6:49 p.m., Seetharam Venkatesh wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java, line 101
> > <https://reviews.apache.org/r/37349/diff/1/?file=1037524#file1037524line101>
> >
> > Seriously? :-)
What else can we do when we copy the code?
> On Aug. 11, 2015, 6:49 p.m., Seetharam Venkatesh wrote:
> > src/conf/solr/currency.xml, line 1
> > <https://reviews.apache.org/r/37349/diff/1/?file=1037526#file1037526line1>
> >
> > Why cant this be repurposed from Titan-solr buindling?
Its not part of titan-solr jar
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/#review94961
-----------------------------------------------------------
On Aug. 11, 2015, 9:32 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37349/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 9:32 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-91
> https://issues.apache.org/jira/browse/ATLAS-91
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4. Added function using reflection to override atlas's SolrIndex
>
>
> Diffs
> -----
>
> client/pom.xml d393b3a
> docs/src/site/twiki/InstallationSteps.twiki 0391c2d
> pom.xml facd539
> repository/pom.xml a2f8e08
> repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 5e61b9a
> src/conf/solr/currency.xml PRE-CREATION
> src/conf/solr/lang/stopwords_en.txt PRE-CREATION
> src/conf/solr/protwords.txt PRE-CREATION
> src/conf/solr/schema.xml PRE-CREATION
> src/conf/solr/solrconfig.xml PRE-CREATION
> src/conf/solr/stopwords.txt PRE-CREATION
> src/conf/solr/synonyms.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37349/diff/
>
>
> Testing
> -------
>
> UTs in distributed profile
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 37349: ATLAS-91 Add solr configuration and
documentation
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37349/#review94961
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java (line 19)
<https://reviews.apache.org/r/37349/#comment149695>
Why cant I retain the titan package here? Dont you think this becomes confusing?
repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java (line 101)
<https://reviews.apache.org/r/37349/#comment149696>
Seriously? :-)
src/conf/solr/currency.xml (line 1)
<https://reviews.apache.org/r/37349/#comment149697>
Why cant this be repurposed from Titan-solr buindling?
src/conf/solr/protwords.txt (line 1)
<https://reviews.apache.org/r/37349/#comment149698>
Why cant this be repurposed from Titan-solr buindling?
src/conf/solr/schema.xml (line 1)
<https://reviews.apache.org/r/37349/#comment149699>
Why cant this be repurposed from Titan-solr buindling?
src/conf/solr/solrconfig.xml (line 1)
<https://reviews.apache.org/r/37349/#comment149700>
Arent these defaults? Why have them in atlas namespace?
- Seetharam Venkatesh
On Aug. 11, 2015, 9:32 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37349/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 9:32 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-91
> https://issues.apache.org/jira/browse/ATLAS-91
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Copied SolrIndex.java from titan codebase to atlas to support solr5 with titan 0.5.4. Added function using reflection to override atlas's SolrIndex
>
>
> Diffs
> -----
>
> client/pom.xml d393b3a
> docs/src/site/twiki/InstallationSteps.twiki 0391c2d
> pom.xml facd539
> repository/pom.xml a2f8e08
> repository/src/main/java/org/apache/atlas/repository/graph/Solr5Index.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 5e61b9a
> src/conf/solr/currency.xml PRE-CREATION
> src/conf/solr/lang/stopwords_en.txt PRE-CREATION
> src/conf/solr/protwords.txt PRE-CREATION
> src/conf/solr/schema.xml PRE-CREATION
> src/conf/solr/solrconfig.xml PRE-CREATION
> src/conf/solr/stopwords.txt PRE-CREATION
> src/conf/solr/synonyms.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37349/diff/
>
>
> Testing
> -------
>
> UTs in distributed profile
>
>
> Thanks,
>
> Shwetha GS
>
>