You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/17 01:12:24 UTC

[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #973: [CELEBORN-8] [ISSUE-952][FEATURE] support register shuffle task in map partition mode

RexXiong commented on code in PR #973:
URL: https://github.com/apache/incubator-celeborn/pull/973#discussion_r1024659142


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -394,7 +444,8 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
             .values()
             .asScala
             .flatMap(_.getAllMasterLocationsWithMinEpoch(shuffleId.toString).asScala)
-            .filter(_.getEpoch == 0)
+            .filter(p =>
+              (partitionType == PartitionType.REDUCE && p.getEpoch == 0) || (partitionType == PartitionType.MAP && p.getId == partitionId))

Review Comment:
   No, but for map partition only one "partition-location-Id" for the map task.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org