You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/07/03 19:15:05 UTC
[GitHub] [storm] srdo commented on a change in pull request #3065:
STORM-3449: autocreds: fix all checkstyle warnings
srdo commented on a change in pull request #3065: STORM-3449: autocreds: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3065#discussion_r300116706
##########
File path: external/storm-autocreds/src/main/java/org/apache/storm/hive/security/AutoHiveCommand.java
##########
@@ -15,51 +15,53 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.storm.hive.security;
-import org.apache.hadoop.hive.conf.HiveConf;
-import org.apache.storm.Config;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import static org.apache.storm.hive.security.HiveSecurityUtil.HIVE_KEYTAB_FILE_KEY;
+import static org.apache.storm.hive.security.HiveSecurityUtil.HIVE_PRINCIPAL_KEY;
-import javax.security.auth.Subject;
import java.util.HashMap;
import java.util.Map;
+import javax.security.auth.Subject;
-import static org.apache.storm.hive.security.HiveSecurityUtil.HIVE_KEYTAB_FILE_KEY;
-import static org.apache.storm.hive.security.HiveSecurityUtil.HIVE_PRINCIPAL_KEY;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.storm.Config;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
- * Command tool of Hive credential renewer
+ * Command tool of Hive credential renewer.
*/
public final class AutoHiveCommand {
- private static final Logger LOG = LoggerFactory.getLogger(AutoHiveCommand.class);
+ private static final Logger LOG = LoggerFactory.getLogger(AutoHiveCommand.class);
- private AutoHiveCommand() {
- }
+ private AutoHiveCommand() {
+ }
- @SuppressWarnings("unchecked")
- public static void main(String[] args) throws Exception {
- Map<String, Object> conf = new HashMap<>();
- conf.put(HIVE_PRINCIPAL_KEY, args[1]); // hive principal storm-hive@WITZEN.COM
- conf.put(HIVE_KEYTAB_FILE_KEY, args[2]); // storm hive keytab /etc/security/keytabs/storm-hive.keytab
- conf.put(HiveConf.ConfVars.METASTOREURIS.varname, args[3]); // hive.metastore.uris : "thrift://pm-eng1-cluster1.field.hortonworks.com:9083"
+ @SuppressWarnings("unchecked")
+ public static void main(String[] args) throws Exception {
+ Map<String, Object> conf = new HashMap<>();
+ conf.put(HIVE_PRINCIPAL_KEY, args[1]); // hive principal storm-hive@WITZEN.COM
+ conf.put(HIVE_KEYTAB_FILE_KEY, args[2]); // storm hive keytab /etc/security/keytabs/storm-hive.keytab
+ conf.put(HiveConf.ConfVars.METASTOREURIS.varname, args[3]);
+ // hive.metastore.uris : "thrift://pm-eng1-cluster1.field.hortonworks.com:9083"
Review comment:
Please put this above the line it's commenting on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services