[GitHub] [helix] alirezazamani commented on a change in pull request #872: Change the cluster creation logic

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #872: Change the cluster creation logic
URL: https://github.com/apache/helix/pull/872#discussion_r389045096
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
 ##########
 @@ -355,7 +356,7 @@ public void testDropInstance() throws Exception {
 
     // add fake liveInstance
     ZKHelixDataAccessor accessor =
-        new ZKHelixDataAccessor(clusterName, new ZkBaseDataAccessor<ZNRecord>(_gZkClient));
+        new ZKHelixDataAccessor(clusterName, new ZkBaseDataAccessor<ZNRecord>(ZK_ADDR));
 
 Review comment:
   The method has been deprecated in November 2019. So I think it is almost recent. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org