You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/20 10:50:34 UTC

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20

MartijnVisser commented on code in PR #21049:
URL: https://github.com/apache/flink/pull/21049#discussion_r1000469655


##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -195,6 +201,17 @@ under the License.
 										<exclude>META-INF/NOTICE.txt</exclude>
 									</excludes>
 								</filter>
+								<filter>
+									<artifact>*:*</artifact>
+									<excludes>
+										<!-- Only some of these licenses actually apply to the JAR and have been manually
+											 placed in this module's resources directory. -->
+										<exclude>LICENSE</exclude>
+										<!-- Only parts of NOTICE file actually apply to the netty JAR and have been manually
+											 copied into this modules's NOTICE file. -->
+										<exclude>NOTICE</exclude>
+									</excludes>

Review Comment:
   This needs a second check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org