You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/26 03:05:51 UTC

[GitHub] [ozone] ChenSammi commented on pull request #2435: HDDS-5437. Move dead DN out of topology

ChenSammi commented on pull request #2435:
URL: https://github.com/apache/ozone/pull/2435#issuecomment-886335962


   Thanks @JacksonYao287 for working on this. 
   
   When a DN registered,  the DatanodeDetails instance which presents DN is added into both Topology tree and nodeStateManager.  nodeStateManager is used more frequently than Topology to get a DN's info.  Would you add a Precondition check that 
   1. after DN is removed from topology,  DatanodeDetails instance returned from nodeStateManager has no parent. 
   2. after DN is added back into topology,  DatanodeDetails instance returned from nodeStateManager has parent correctly set.   
   
   And would you add a new UT for it. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org