You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/05/19 21:24:00 UTC
[jira] [Commented] (NIFI-8161) NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
[ https://issues.apache.org/jira/browse/NIFI-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724412#comment-17724412 ]
ASF subversion and git services commented on NIFI-8161:
-------------------------------------------------------
Commit 8a4c3cab84253308c2f7fa4eda4a4221c73545e2 in nifi's branch refs/heads/main from Arek Burdach
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8a4c3cab84 ]
NIFI-8161 Migrated EL from SimpleDateFormat to DateTimeFormatter
This closes #7169
Signed-off-by: David Handermann <ex...@apache.org>
> NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
> -------------------------------------------------------------
>
> Key: NIFI-8161
> URL: https://issues.apache.org/jira/browse/NIFI-8161
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Arek Burdach
> Assignee: Arek Burdach
> Priority: Major
> Labels: perfomance, pull-request-available
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> In NiFi Expression Language we are commonly using SimpleDateFormat. It is old, inefficient approach: due to mutability of SimpleDateFormat it need to be recreated for each operation. Also this format is lax in some places where user would like to be more strict. In my opinion better approach would be usage of java8 DateTimeFormatter instead.
> I've done some benchmarks that you can check on your own in FormatEvaluatorBenchmark. Results on my 8-core, i7-1065G7:
> - before change (SimpleDateFormat): 11.230 ± 5.407 us/op
> - after switching to DateTimeFormatter API: 4.747 ± 0.426 us/op
> - after introduction of preparation of formatter for literal formats: 2.025 ± 0.055 us/op
> This change is not 100% transparent so some changes might be necessary in users code. Most of differences are visible in modifications that I've made in TestQuery tests:
> - back tick (`) for escaping of extra characters is not supported anymore - only single quote is supported
> - "repeated" syntax like "dd" for days strictly check if two digits were provided - if someone need to use more lax syntax, need to use single "d" syntax
> [update]
> After switching to lenient mode, parsing is compatible with SimpleDateFormat in second point ("repeated" syntax)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)