[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics

["smallzhongfeng (via GitHub)" <gi...@apache.org>]

smallzhongfeng commented on code in PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#discussion_r1130526570


##########
coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java:
##########
@@ -89,7 +89,14 @@ public void testCoordinatorMetrics() throws Exception {
     ObjectMapper mapper = new ObjectMapper();
     JsonNode actualObj = mapper.readTree(content);
     assertEquals(2, actualObj.size());
-    assertEquals(10, actualObj.get("metrics").size());
+    int actualMetrics = 0;
+    for (JsonNode metrics : actualObj.get("metrics")) {
+      if (CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {

Review Comment:
   Thanks for your advice, I have tried this method, but it still doesn't work. I don't think it's the reason why the monitoring didn't clean up, but when I ran the GA, it seems like reading the latest indicators of other uts. I tried to modify the default `JETTY_ HTTP_ PORT` and `RPC_ SERVER_ PORT`, but still not effective.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org