You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by "Beyyes (via GitHub)" <gi...@apache.org> on 2025/03/13 02:41:50 UTC

Re: [PR] Implement column name match when query in TableModel [iotdb]

Beyyes commented on code in PR #14928:
URL: https://github.com/apache/iotdb/pull/14928#discussion_r1992578585


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/ExpressionAnalyzer.java:
##########
@@ -1150,6 +1151,11 @@ protected Type visitNode(Node node, StackableAstVisitorContext<Context> context)
           String.format("not yet implemented: %s", node.getClass().getName()));
     }
 
+    @Override
+    protected Type visitColumns(Columns node, StackableAstVisitorContext<Context> context) {
+      throw new IllegalStateException("Columns shouldn't appear in Expression Analyze");

Review Comment:
   SemanticException (701 error code) is better.
   ![image](https://github.com/user-attachments/assets/6a6ab772-5dc0-4259-b2c9-10bda91fed99)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org