[GitHub] [cordova-android] sagrawal31 commented on a change in pull request #1173: Feature: Write name of the Android app to .idea/.name for Android Studio

[GitBox <gi...@apache.org>]

sagrawal31 commented on a change in pull request #1173:
URL: https://github.com/apache/cordova-android/pull/1173#discussion_r601743925



##########
File path: spec/unit/create.spec.js
##########
@@ -300,4 +301,23 @@ describe('create', function () {
             });
         });
     });
+
+    describe('writeNameForAndroidStudio', () => {
+        var project_path = path.join('some', 'path');

Review comment:
       Well, I love ES6 (and TypeScripe) but when I always try to follow the pattern of existing code and found that existing code is using `var` mostly and using snake case variables, so used `var`. Thanks anyways. Updated this for new code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org