You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by ben-craig <gi...@git.apache.org> on 2015/07/15 17:58:17 UTC
[GitHub] thrift pull request: THRIFT-3246 Reduce the number of trivial warn...
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/553
THRIFT-3246 Reduce the number of trivial warnings in Windows C++ CMake builds
Warnings still exist, but I'm down to 18 in a debug build instead of the 145 that are present in debug build of master.
Some of the general techniques I'm using:
* Removing exception object names from places that didn't use the exception object. This fixes 'unreferenced local variable' warnings.
* Disabling 'inheriting methods via dominance' warning at the compiler level. In these situations, 'dominance' is the intentional behavior.
* disabling the 'very long identifier was truncated' warning that resulted from our 'insanity' tests.
* more accurately reproducing function signature by making 'const <integer_type>' in parameter lists. This fixes C4373 'virtual function overrides <foo>, previouis versions of the compiler did not override when parameters only differed by const / volatile qualifiers.'
* Adding some explicit int / double casts to fix possible loss of data warnings.
* Removing exception specifications, which have been deprecated in C++11, and cause warnings in MSVC 2013 (C4290).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ben-craig/thrift THRIFT-3246
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/553.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #553
----
commit 7a7495205e8830a9196f0a7446aa7997531bacc2
Author: ben-craig <be...@gmail.com>
Date: 2015-07-15T14:34:53Z
Drastically reducing number of msvc warnings
commit 9015c0592a7afa5d5bd9ba4db72c14920644960a
Author: ben-craig <be...@gmail.com>
Date: 2015-07-15T14:36:44Z
Merge branch 'master' of https://github.com/apache/thrift into dominance
commit b9fa580b73fff056fba97dd6389e6bded833e08e
Author: ben-craig <be...@gmail.com>
Date: 2015-07-15T15:42:59Z
Merge branch 'master' of https://github.com/apache/thrift into THRIFT-3246
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3246 Reduce the number of trivial warn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---