You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Patricia Shanahan <pa...@acm.org> on 2015/06/02 01:02:45 UTC

qa-refactor-namespace observations

I have checked out the qa-refactor-namespace branch, and done some 
initial checks. I noticed a couple of possible issues:

Extensive use of old package names in package 
org.apache.river.example.hello.

qa contains a binary file, tmp, that includes "com.sun". Should it 
really be checked in to SVN? If so, I don't like "tmp" as a name.

Patricia


Re: qa-refactor-namespace observations

Posted by Greg Trasuk <tr...@stratuscom.com>.
+1 net.ini stays!

Greg Trasuk

> On Jun 1, 2015, at 7:52 PM, Dennis Reedy <de...@gmail.com> wrote:
> 
> On Mon, Jun 1, 2015 at 7:48 PM, Patricia Shanahan <pats@acm.org <ma...@acm.org>> wrote:
> 
>> On 6/1/2015 4:33 PM, Dennis Reedy wrote:
>> 
>>> Patricia,
>>> 
>>> I just did a clean checkout of the qa-refactor-namespace branch, and I do
>>> not see any references of old package names in package
>>> org.apache.river.example.hello.I'm looking for com.sun.jini, perhaps I'm
>>> missing something.
>>> 
>> 
>> I was also looking for "net.jini". We did get the domain name and transfer
>> it to Apache some years ago, so there is a case for keeping it. However, I
>> don't know whether Apache is maintaining, and will continue to maintain,
>> the registration, and this seems like a good time to put everything
>> possible in the org.apache.river space.
> 
> 
> We actually do not want to do that. The net.jini namespace remains intact,
> the com.sun.jini name space gets moved over to org.apache.river
> 
> Regards
> 
> Dennis


Re: qa-refactor-namespace observations

Posted by Patricia Shanahan <pa...@acm.org>.
No problem since keeping net.jini was a deliberate decision.

On 6/1/2015 4:52 PM, Dennis Reedy wrote:
> On Mon, Jun 1, 2015 at 7:48 PM, Patricia Shanahan <pa...@acm.org> wrote:
>
>> On 6/1/2015 4:33 PM, Dennis Reedy wrote:
>>
>>> Patricia,
>>>
>>> I just did a clean checkout of the qa-refactor-namespace branch, and I do
>>> not see any references of old package names in package
>>> org.apache.river.example.hello.I'm looking for com.sun.jini, perhaps I'm
>>> missing something.
>>>
>>
>> I was also looking for "net.jini". We did get the domain name and transfer
>> it to Apache some years ago, so there is a case for keeping it. However, I
>> don't know whether Apache is maintaining, and will continue to maintain,
>> the registration, and this seems like a good time to put everything
>> possible in the org.apache.river space.
>
>
> We actually do not want to do that. The net.jini namespace remains intact,
> the com.sun.jini name space gets moved over to org.apache.river
>
> Regards
>
> Dennis
>

Re: qa-refactor-namespace observations

Posted by Dennis Reedy <de...@gmail.com>.
On Mon, Jun 1, 2015 at 7:48 PM, Patricia Shanahan <pa...@acm.org> wrote:

> On 6/1/2015 4:33 PM, Dennis Reedy wrote:
>
>> Patricia,
>>
>> I just did a clean checkout of the qa-refactor-namespace branch, and I do
>> not see any references of old package names in package
>> org.apache.river.example.hello.I'm looking for com.sun.jini, perhaps I'm
>> missing something.
>>
>
> I was also looking for "net.jini". We did get the domain name and transfer
> it to Apache some years ago, so there is a case for keeping it. However, I
> don't know whether Apache is maintaining, and will continue to maintain,
> the registration, and this seems like a good time to put everything
> possible in the org.apache.river space.


We actually do not want to do that. The net.jini namespace remains intact,
the com.sun.jini name space gets moved over to org.apache.river

Regards

Dennis

Re: qa-refactor-namespace observations

Posted by Patricia Shanahan <pa...@acm.org>.
On 6/1/2015 4:33 PM, Dennis Reedy wrote:
> Patricia,
>
> I just did a clean checkout of the qa-refactor-namespace branch, and I do
> not see any references of old package names in package
> org.apache.river.example.hello.I'm looking for com.sun.jini, perhaps I'm
> missing something.

I was also looking for "net.jini". We did get the domain name and 
transfer it to Apache some years ago, so there is a case for keeping it. 
However, I don't know whether Apache is maintaining, and will continue 
to maintain, the registration, and this seems like a good time to put 
everything possible in the org.apache.river space.

>
> I do see an issue with
> qa/jtreg/net/jini/jeri/transport/multihomed/config/policy.kerbmultihome,
> that might need to be remedied, but aside from that file, where exactly do
> you see the issue?
>
> With regard to the binary file, I'm not sure what its significance is.

I can look at the source code to see what I can find out. I am not yet 
up to doing a build, so it would be helpful if you could do a couple of 
tests:

Try deleting it, and see what, if anything, changes.

If that does not go well, try running with it there and see if it 
changes to get rid of the "com.sun".

>
> Regards
>
> Dennis
>
>
> On Mon, Jun 1, 2015 at 7:02 PM, Patricia Shanahan <pa...@acm.org> wrote:
>
>> I have checked out the qa-refactor-namespace branch, and done some initial
>> checks. I noticed a couple of possible issues:
>>
>> Extensive use of old package names in package
>> org.apache.river.example.hello.
>>
>> qa contains a binary file, tmp, that includes "com.sun". Should it really
>> be checked in to SVN? If so, I don't like "tmp" as a name.
>>
>> Patricia
>>
>>
>

Re: qa-refactor-namespace observations

Posted by Dennis Reedy <de...@gmail.com>.
Patricia,

I just did a clean checkout of the qa-refactor-namespace branch, and I do
not see any references of old package names in package
org.apache.river.example.hello.I'm looking for com.sun.jini, perhaps I'm
missing something.

I do see an issue with
qa/jtreg/net/jini/jeri/transport/multihomed/config/policy.kerbmultihome,
that might need to be remedied, but aside from that file, where exactly do
you see the issue?

With regard to the binary file, I'm not sure what its significance is.

Regards

Dennis


On Mon, Jun 1, 2015 at 7:02 PM, Patricia Shanahan <pa...@acm.org> wrote:

> I have checked out the qa-refactor-namespace branch, and done some initial
> checks. I noticed a couple of possible issues:
>
> Extensive use of old package names in package
> org.apache.river.example.hello.
>
> qa contains a binary file, tmp, that includes "com.sun". Should it really
> be checked in to SVN? If so, I don't like "tmp" as a name.
>
> Patricia
>
>