You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/02/12 13:46:05 UTC
Change in asterixdb[neo]: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243 )
Change subject: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
......................................................................
[NO ISSUE][HTTP] Fork the close of response stream on interrupt
Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
---
M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/15243/1
diff --git a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
index e433c02..9f01123 100644
--- a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
+++ b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
@@ -236,7 +236,13 @@
try {
return readFuture.get();
} catch (InterruptedException ex) { // NOSONAR -- interrupt or rethrow
- response.close();
+ executor.submit(() -> {
+ try {
+ response.close();
+ } catch (IOException e) {
+ LOGGER.debug("{} ignoring exception thrown on stream close due to interrupt", description, e);
+ }
+ });
try {
readFuture.get(1, TimeUnit.SECONDS);
} catch (TimeoutException te) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
Gerrit-Change-Number: 15243
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[neo]: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243 )
Change subject: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/12962/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
Gerrit-Change-Number: 15243
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Sat, 12 Feb 2022 16:50:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243 )
Change subject: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
......................................................................
[NO ISSUE][HTTP] Fork the close of response stream on interrupt
Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
---
M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/15243/1
diff --git a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
index e433c02..9f01123 100644
--- a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
+++ b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
@@ -236,7 +236,13 @@
try {
return readFuture.get();
} catch (InterruptedException ex) { // NOSONAR -- interrupt or rethrow
- response.close();
+ executor.submit(() -> {
+ try {
+ response.close();
+ } catch (IOException e) {
+ LOGGER.debug("{} ignoring exception thrown on stream close due to interrupt", description, e);
+ }
+ });
try {
readFuture.get(1, TimeUnit.SECONDS);
} catch (TimeoutException te) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
Gerrit-Change-Number: 15243
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[neo]: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243 )
Change subject: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
......................................................................
Removed Verified-1 by Jenkins <je...@fulliautomatix.ics.uci.edu>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
Gerrit-Change-Number: 15243
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Al Hubail <mh...@uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-MessageType: deleteVote
Change in asterixdb[neo]: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243 )
Change subject: [NO ISSUE][HTTP] Fork the close of response stream on interrupt
......................................................................
Patch Set 1: Verified+1 Code-Review+1
Seen on Java 17, a close on a response on a stuck stream does not return until the socket timeout is reached.
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15243
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I0a49ae5b1d3d59f68e769bef45c39e0242e312bc
Gerrit-Change-Number: 15243
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Al Hubail <mh...@uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 17:00:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment