You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ds...@apache.org on 2017/04/18 21:02:12 UTC
lucene-solr:master: SOLR-10439: 'large' was forgotten in
/schema/fields?showDefaults=true
Repository: lucene-solr
Updated Branches:
refs/heads/master 10772121e -> 8347169ab
SOLR-10439: 'large' was forgotten in /schema/fields?showDefaults=true
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8347169a
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/8347169a
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/8347169a
Branch: refs/heads/master
Commit: 8347169ab3988e974e74c5e238dce9cc53d81f75
Parents: 1077212
Author: David Smiley <ds...@apache.org>
Authored: Tue Apr 18 17:02:07 2017 -0400
Committer: David Smiley <ds...@apache.org>
Committed: Tue Apr 18 17:02:07 2017 -0400
----------------------------------------------------------------------
solr/CHANGES.txt | 2 ++
solr/core/src/java/org/apache/solr/schema/SchemaField.java | 1 +
.../src/test/org/apache/solr/rest/schema/TestFieldResource.java | 3 ++-
3 files changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index b009951..e865311 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -294,6 +294,8 @@ Bug Fixes
* SOLR-10420: Solr 6.x leaking one SolrZkClient instance per second (Scott Blum, Cao Manh Dat, Markus Jelsma, Steve Rowe)
+* SOLR-10439: The new 'large' attribute had been forgotten in /schema/fields?showDefaults=true
+
================== 6.5.0 ==================
Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/schema/SchemaField.java b/solr/core/src/java/org/apache/solr/schema/SchemaField.java
index d35d842..c2e8cca 100644
--- a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
+++ b/solr/core/src/java/org/apache/solr/schema/SchemaField.java
@@ -336,6 +336,7 @@ public final class SchemaField extends FieldProperties implements IndexableField
properties.add(getPropertyName(OMIT_POSITIONS), omitPositions());
properties.add(getPropertyName(STORE_OFFSETS), storeOffsetsWithPositions());
properties.add(getPropertyName(MULTIVALUED), multiValued());
+ properties.add(getPropertyName(LARGE_FIELD), isLarge());
if (sortMissingFirst()) {
properties.add(getPropertyName(SORT_MISSING_FIRST), sortMissingFirst());
} else if (sortMissingLast()) {
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
index d591b9a..4f53609 100644
--- a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
+++ b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
@@ -23,7 +23,7 @@ public class TestFieldResource extends SolrRestletTestBase {
public void testGetField() throws Exception {
assertQ("/schema/fields/test_postv?indent=on&wt=xml&showDefaults=true",
"count(/response/lst[@name='field']) = 1",
- "count(/response/lst[@name='field']/*) = 17",
+ "count(/response/lst[@name='field']/*) = 18",
"/response/lst[@name='field']/str[@name='name'] = 'test_postv'",
"/response/lst[@name='field']/str[@name='type'] = 'text'",
"/response/lst[@name='field']/bool[@name='indexed'] = 'true'",
@@ -38,6 +38,7 @@ public class TestFieldResource extends SolrRestletTestBase {
"/response/lst[@name='field']/bool[@name='omitPositions'] = 'false'",
"/response/lst[@name='field']/bool[@name='storeOffsetsWithPositions'] = 'false'",
"/response/lst[@name='field']/bool[@name='multiValued'] = 'false'",
+ "/response/lst[@name='field']/bool[@name='large'] = 'false'",
"/response/lst[@name='field']/bool[@name='required'] = 'false'",
"/response/lst[@name='field']/bool[@name='tokenized'] = 'true'",
"/response/lst[@name='field']/bool[@name='useDocValuesAsStored'] = 'true'");
Re: lucene-solr:master: SOLR-10439: 'large' was forgotten in /schema/fields?showDefaults=true
Posted by David Smiley <da...@gmail.com>.
(I replied to your similar comment on the JIRA issue)
On Tue, Apr 18, 2017 at 7:05 PM Chris Hostetter <ho...@fucit.org>
wrote:
>
> David: doesn't this same bug affect /schema/fieldType ?
>
> Can't large="true" be specified on fieldType as a default for all fields
> that inherit from that type?
>
> Also: what about /schema/dynamicfields ?
>
>
>
>
> : Date: Tue, 18 Apr 2017 21:02:12 +0000 (UTC)
> : From: dsmiley@apache.org
> : Reply-To: dev@lucene.apache.org
> : To: commits@lucene.apache.org
> : Subject: lucene-solr:master: SOLR-10439: 'large' was forgotten in
> : /schema/fields?showDefaults=true
> :
> : Repository: lucene-solr
> : Updated Branches:
> : refs/heads/master 10772121e -> 8347169ab
> :
> :
> : SOLR-10439: 'large' was forgotten in /schema/fields?showDefaults=true
> :
> :
> : Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> : Commit:
> http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8347169a
> : Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/8347169a
> : Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/8347169a
> :
> : Branch: refs/heads/master
> : Commit: 8347169ab3988e974e74c5e238dce9cc53d81f75
> : Parents: 1077212
> : Author: David Smiley <ds...@apache.org>
> : Authored: Tue Apr 18 17:02:07 2017 -0400
> : Committer: David Smiley <ds...@apache.org>
> : Committed: Tue Apr 18 17:02:07 2017 -0400
> :
> : ----------------------------------------------------------------------
> : solr/CHANGES.txt | 2 ++
> : solr/core/src/java/org/apache/solr/schema/SchemaField.java | 1 +
> : .../src/test/org/apache/solr/rest/schema/TestFieldResource.java | 3
> ++-
> : 3 files changed, 5 insertions(+), 1 deletion(-)
> : ----------------------------------------------------------------------
> :
> :
> :
> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/CHANGES.txt
> : ----------------------------------------------------------------------
> : diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> : index b009951..e865311 100644
> : --- a/solr/CHANGES.txt
> : +++ b/solr/CHANGES.txt
> : @@ -294,6 +294,8 @@ Bug Fixes
> :
> : * SOLR-10420: Solr 6.x leaking one SolrZkClient instance per second
> (Scott Blum, Cao Manh Dat, Markus Jelsma, Steve Rowe)
> :
> : +* SOLR-10439: The new 'large' attribute had been forgotten in
> /schema/fields?showDefaults=true
> : +
> : ================== 6.5.0 ==================
> :
> : Consult the LUCENE_CHANGES.txt file for additional, low level, changes
> in this release.
> :
> :
> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
> : ----------------------------------------------------------------------
> : diff --git a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
> b/solr/core/src/java/org/apache/solr/schema/SchemaField.java
> : index d35d842..c2e8cca 100644
> : --- a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
> : +++ b/solr/core/src/java/org/apache/solr/schema/SchemaField.java
> : @@ -336,6 +336,7 @@ public final class SchemaField extends
> FieldProperties implements IndexableField
> : properties.add(getPropertyName(OMIT_POSITIONS), omitPositions());
> : properties.add(getPropertyName(STORE_OFFSETS),
> storeOffsetsWithPositions());
> : properties.add(getPropertyName(MULTIVALUED), multiValued());
> : + properties.add(getPropertyName(LARGE_FIELD), isLarge());
> : if (sortMissingFirst()) {
> : properties.add(getPropertyName(SORT_MISSING_FIRST),
> sortMissingFirst());
> : } else if (sortMissingLast()) {
> :
> :
> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
> : ----------------------------------------------------------------------
> : diff --git
> a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
> b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
> : index d591b9a..4f53609 100644
> : ---
> a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
> : +++
> b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
> : @@ -23,7 +23,7 @@ public class TestFieldResource extends
> SolrRestletTestBase {
> : public void testGetField() throws Exception {
> :
> assertQ("/schema/fields/test_postv?indent=on&wt=xml&showDefaults=true",
> : "count(/response/lst[@name='field']) = 1",
> : - "count(/response/lst[@name='field']/*) = 17",
> : + "count(/response/lst[@name='field']/*) = 18",
> : "/response/lst[@name='field']/str[@name='name'] =
> 'test_postv'",
> : "/response/lst[@name='field']/str[@name='type'] = 'text'",
> : "/response/lst[@name='field']/bool[@name='indexed'] =
> 'true'",
> : @@ -38,6 +38,7 @@ public class TestFieldResource extends
> SolrRestletTestBase {
> : "/response/lst[@name='field']/bool[@name='omitPositions'] =
> 'false'",
> :
> "/response/lst[@name='field']/bool[@name='storeOffsetsWithPositions'] =
> 'false'",
> : "/response/lst[@name='field']/bool[@name='multiValued'] =
> 'false'",
> : + "/response/lst[@name='field']/bool[@name='large'] =
> 'false'",
> : "/response/lst[@name='field']/bool[@name='required'] =
> 'false'",
> : "/response/lst[@name='field']/bool[@name='tokenized'] =
> 'true'",
> :
> "/response/lst[@name='field']/bool[@name='useDocValuesAsStored'] = 'true'");
> :
> :
>
> -Hoss
> http://www.lucidworks.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com
Re: lucene-solr:master: SOLR-10439: 'large' was forgotten in
/schema/fields?showDefaults=true
Posted by Chris Hostetter <ho...@fucit.org>.
David: doesn't this same bug affect /schema/fieldType ?
Can't large="true" be specified on fieldType as a default for all fields
that inherit from that type?
Also: what about /schema/dynamicfields ?
: Date: Tue, 18 Apr 2017 21:02:12 +0000 (UTC)
: From: dsmiley@apache.org
: Reply-To: dev@lucene.apache.org
: To: commits@lucene.apache.org
: Subject: lucene-solr:master: SOLR-10439: 'large' was forgotten in
: /schema/fields?showDefaults=true
:
: Repository: lucene-solr
: Updated Branches:
: refs/heads/master 10772121e -> 8347169ab
:
:
: SOLR-10439: 'large' was forgotten in /schema/fields?showDefaults=true
:
:
: Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
: Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8347169a
: Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/8347169a
: Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/8347169a
:
: Branch: refs/heads/master
: Commit: 8347169ab3988e974e74c5e238dce9cc53d81f75
: Parents: 1077212
: Author: David Smiley <ds...@apache.org>
: Authored: Tue Apr 18 17:02:07 2017 -0400
: Committer: David Smiley <ds...@apache.org>
: Committed: Tue Apr 18 17:02:07 2017 -0400
:
: ----------------------------------------------------------------------
: solr/CHANGES.txt | 2 ++
: solr/core/src/java/org/apache/solr/schema/SchemaField.java | 1 +
: .../src/test/org/apache/solr/rest/schema/TestFieldResource.java | 3 ++-
: 3 files changed, 5 insertions(+), 1 deletion(-)
: ----------------------------------------------------------------------
:
:
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/CHANGES.txt
: ----------------------------------------------------------------------
: diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
: index b009951..e865311 100644
: --- a/solr/CHANGES.txt
: +++ b/solr/CHANGES.txt
: @@ -294,6 +294,8 @@ Bug Fixes
:
: * SOLR-10420: Solr 6.x leaking one SolrZkClient instance per second (Scott Blum, Cao Manh Dat, Markus Jelsma, Steve Rowe)
:
: +* SOLR-10439: The new 'large' attribute had been forgotten in /schema/fields?showDefaults=true
: +
: ================== 6.5.0 ==================
:
: Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
:
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
: ----------------------------------------------------------------------
: diff --git a/solr/core/src/java/org/apache/solr/schema/SchemaField.java b/solr/core/src/java/org/apache/solr/schema/SchemaField.java
: index d35d842..c2e8cca 100644
: --- a/solr/core/src/java/org/apache/solr/schema/SchemaField.java
: +++ b/solr/core/src/java/org/apache/solr/schema/SchemaField.java
: @@ -336,6 +336,7 @@ public final class SchemaField extends FieldProperties implements IndexableField
: properties.add(getPropertyName(OMIT_POSITIONS), omitPositions());
: properties.add(getPropertyName(STORE_OFFSETS), storeOffsetsWithPositions());
: properties.add(getPropertyName(MULTIVALUED), multiValued());
: + properties.add(getPropertyName(LARGE_FIELD), isLarge());
: if (sortMissingFirst()) {
: properties.add(getPropertyName(SORT_MISSING_FIRST), sortMissingFirst());
: } else if (sortMissingLast()) {
:
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8347169a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
: ----------------------------------------------------------------------
: diff --git a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
: index d591b9a..4f53609 100644
: --- a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
: +++ b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java
: @@ -23,7 +23,7 @@ public class TestFieldResource extends SolrRestletTestBase {
: public void testGetField() throws Exception {
: assertQ("/schema/fields/test_postv?indent=on&wt=xml&showDefaults=true",
: "count(/response/lst[@name='field']) = 1",
: - "count(/response/lst[@name='field']/*) = 17",
: + "count(/response/lst[@name='field']/*) = 18",
: "/response/lst[@name='field']/str[@name='name'] = 'test_postv'",
: "/response/lst[@name='field']/str[@name='type'] = 'text'",
: "/response/lst[@name='field']/bool[@name='indexed'] = 'true'",
: @@ -38,6 +38,7 @@ public class TestFieldResource extends SolrRestletTestBase {
: "/response/lst[@name='field']/bool[@name='omitPositions'] = 'false'",
: "/response/lst[@name='field']/bool[@name='storeOffsetsWithPositions'] = 'false'",
: "/response/lst[@name='field']/bool[@name='multiValued'] = 'false'",
: + "/response/lst[@name='field']/bool[@name='large'] = 'false'",
: "/response/lst[@name='field']/bool[@name='required'] = 'false'",
: "/response/lst[@name='field']/bool[@name='tokenized'] = 'true'",
: "/response/lst[@name='field']/bool[@name='useDocValuesAsStored'] = 'true'");
:
:
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org