You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/17 11:51:46 UTC
[GitHub] [rocketmq-mqtt] YxAc opened a new pull request, #72: [ISSUE #71] Rename WebsocketEncoder to WebSocketEncoder and add test
YxAc opened a new pull request, #72:
URL: https://github.com/apache/rocketmq-mqtt/pull/72
fixed #71
- rename WebsocketEncoder to WebSocketEncoder;
- add unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #72: [ISSUE #71] Rename WebsocketEncoder to WebSocketEncoder and add test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #72:
URL: https://github.com/apache/rocketmq-mqtt/pull/72#issuecomment-1100861161
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#72](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1202d0) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/1393642c2397a72077892771883be9d5750611e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1393642) will **increase** coverage by `0.52%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 26.91% 27.44% +0.52%
==========================================
Files 97 97
Lines 4187 4187
Branches 660 660
==========================================
+ Hits 1127 1149 +22
+ Misses 2832 2803 -29
- Partials 228 235 +7
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/rocketmq/mqtt/cs/starter/MqttServer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zdGFydGVyL01xdHRTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rocketmq/mqtt/cs/protocol/ws/WebSocketEncoder.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC93cy9XZWJTb2NrZXRFbmNvZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...mq/mqtt/cs/protocol/ws/WebSocketServerHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC93cy9XZWJTb2NrZXRTZXJ2ZXJIYW5kbGVyLmphdmE=) | `39.53% <0.00%> (+39.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1393642...b1202d0](https://codecov.io/gh/apache/rocketmq-mqtt/pull/72?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing merged pull request #72: [ISSUE #71] Rename WebsocketEncoder to WebSocketEncoder and add test
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #72:
URL: https://github.com/apache/rocketmq-mqtt/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org