You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/05/16 18:37:00 UTC
[jira] [Commented] (IMPALA-12121) Add non empty check for UDF location in getLastModifiedTime method
[ https://issues.apache.org/jira/browse/IMPALA-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723254#comment-17723254 ]
ASF subversion and git services commented on IMPALA-12121:
----------------------------------------------------------
Commit cf28a4c5292fdb3504d1fe11183c78243ed148a4 in impala's branch refs/heads/master from Soumyakanti Das
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cf28a4c52 ]
IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
getLastModifiedTime() of Function.java assumes that if the UDF is not a BUILTIN
and if the location is not null, it is a non-empty string. However, we may have
UDFs with an empty location if they are in the install location and loaded at
init time.
This patch introduces an isBuiltinOrJava() method that checks if the function is
BUILTIN, or a JAVA function with blank location.
Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Reviewed-on: http://gerrit.cloudera.org:8080/19852
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Add non empty check for UDF location in getLastModifiedTime method
> ------------------------------------------------------------------
>
> Key: IMPALA-12121
> URL: https://issues.apache.org/jira/browse/IMPALA-12121
> Project: IMPALA
> Issue Type: Improvement
> Components: fe
> Reporter: Soumyakanti Das
> Priority: Major
>
> {{getLastModifiedTime()}} of {{Function.java}} assumes that if the UDF is not a BUILTIN and if the location is not null, it is a non-empty string. However, we may have UDFs with an empty location if they are in the install location and loaded at init time.
> We should also add a non empty check for the location in the if condition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org